PR#168: Don't send SIGKILL to children, give them a chance to die - certmonger

certmonger

#168 Don't send SIGKILL to children, give them a chance to die

Merged 3 years ago by rcritten. Opened 3 years ago by rcritten.

rcritten/certmonger nochildkill into master

Don't send SIGKILL to children, give them a chance to die

Rob Crittenden • 3 years ago

00e9480

src/subproc.c

file modified

-1

		`@@ -240,7 +240,6 @@`

		`if (state != NULL) {`
		`if (state->pid != -1) {`
		`- kill(state->pid, SIGKILL);`
		`do {`
		`pid = waitpid(state->pid, &state->status, 0);`
		`cm_log(4, "Waited for %ld, got %ld.\n",`

rcritten commented 3 years ago

This was causing issues in IPA which uses a lock file to
serialize some operations. The kill was leaving the lock in
place causing things to time out.