PR#115: Change /var/run -> /run in systemd service file - certmonger

certmonger

#115 Change /var/run -> /run in systemd service file

Merged 4 years ago by rcritten. Opened 4 years ago by orion.

orion/certmonger systemd into master

Change /var/run -> /run in systemd service file

Orion Poplawski • 4 years ago

c2687bd

systemd/certmonger.service.in

file modified

+2 -2

		`@@ -4,9 +4,9 @@`

		`[Service]`
		`Type=dbus`
		`- PIDFile=/var/run/certmonger.pid`
		`+ PIDFile=/run/certmonger.pid`
		`EnvironmentFile=-/etc/sysconfig/certmonger`
		`- ExecStart=/usr/sbin/certmonger -S -p /var/run/certmonger.pid -n $OPTS`
		`+ ExecStart=/usr/sbin/certmonger -S -p /run/certmonger.pid -n $OPTS`
		`BusName=@CM_DBUS_NAME@`

		`[Install]`

orion commented 4 years ago

Fixes: /usr/lib/systemd/system/certmonger.service:6: PIDFile= references path below legacy directory /var/run/, updating /var/run/certmonger.pid → /run/certmonger.pid; please update the unit file accordingly.

rcritten commented 4 years ago

Code looks good. Can you add a reference to the commit that this change is required because of systemd 239 so we'll have more context in the future? And add a reference to the ticket that someone else opened on this issue as well?

My suggestion would be:

Change /var/run -> /run in systemd service file

systemd 239 complains about the legacy of certmonger's tmpfiles which are located on /var/run.

https://pagure.io/certmonger/issue/111

rebased onto 89bc23f346437f35f9d533fcfcf5b022e02ba1d6

4 years ago

orion commented 4 years ago

Thanks, changed.

rcritten commented 4 years ago

Ah crap, sorry, I conflated two separate issues. There is a separate problem with tmpfiles.d but that is controlled by how certmonger is configured, --with-tmpdir, which in Fedora is /var/run/certmonger and needs to be made downstream.

That is a different but similar error from what you are fixing here, the systemd PID directory.

So, sorry for the churn, but can you change the commit message one last time to something like:

Change /var/run -> /run in systemd service file

systemd 239 complains about the legacy of certmonger's PID file which is located in /var/run.

Signed-off-by: Orion Poplawski orion@nwra.com

Basically slight re-wording of the systemd message and drop the ticket #.

rebased onto c2687bd

4 years ago

orion commented 4 years ago

No worries. Done.

rcritten commented 4 years ago

Thanks, ack.