#122 test suite fails with '--disable-dsa'
Closed: fixed 5 months ago by rcritten. Opened 6 months ago by slev.

I run certmonger test suite. Certmonger is configured with --disable-dsa.
There is an error:

Running test 027-hooks... OK                                                    
Running test 028-dbus... Files /usr/src/tmp/runtests7OwGho and expected.out differ
Files /usr/src/tmp/runtests7OwGho and expected.out.nodsa differ                 
FAIL                                                                            
--- expected.out        2019-02-21 13:05:36.000000000 +0000                     
+++ actual      2019-08-14 07:00:26.075643016 +0000                             
@@ -187,7 +187,7 @@                                                             
 dbus.Array([dbus.ObjectPath('/org/fedorahosted/certmonger/requests/Request2')], signature=dbus.Signature('o'))

 [ /org/fedorahosted/certmonger: org.fedorahosted.certmonger.get_supported_key_types ]
-dbus.Array([dbus.String(u'RSA'), dbus.String(u'DSA'), dbus.String(u'EC')], signature=dbus.Signature('s'))
+dbus.Array([dbus.String(u'RSA'), dbus.String(u'EC')], signature=dbus.Signature('s'))

 [ /org/fedorahosted/certmonger: org.fedorahosted.certmonger.get_supported_key_storage ]
 dbus.Array([dbus.String(u'NSSDB'), dbus.String(u'FILE')], signature=dbus.Signature('s'))
@@ -713,7 +713,7 @@                                                             
 </node>                                                                        

 [ /org/fedorahosted/certmonger/cas/CA2: org.fedorahosted.certmonger.ca.get_config_file_path ]
-$tmpdir/cas/20180327134236                                                     
+$tmpdir/cas/20190814070007                                                     

 [ /org/fedorahosted/certmonger/cas/CA2: org.fedorahosted.certmonger.ca.get_nickname ]
 SelfSign                                                                       
@@ -828,7 +828,7 @@                                                             
 </node>                                                                        

 [ /org/fedorahosted/certmonger/cas/CA3: org.fedorahosted.certmonger.ca.get_config_file_path ]
-$tmpdir/cas/20180327134236-1                                                   
+$tmpdir/cas/20190814070007-1                                                   

 [ /org/fedorahosted/certmonger/cas/CA3: org.fedorahosted.certmonger.ca.get_nickname ]
 IPA                                                                            
@@ -941,7 +941,7 @@                                                             
 </node>                                                                        

  [ /org/fedorahosted/certmonger/cas/CA4: org.fedorahosted.certmonger.ca.get_config_file_path ]
-$tmpdir/cas/20180327134236-2                                                   
+$tmpdir/cas/20190814070007-2

 [ /org/fedorahosted/certmonger/cas/CA4: org.fedorahosted.certmonger.ca.get_nickname ]
 certmaster                                                                     
@@ -1054,7 +1054,7 @@                                                           
 </node>                                                                        

 [ /org/fedorahosted/certmonger/cas/CA5: org.fedorahosted.certmonger.ca.get_config_file_path ]
-$tmpdir/cas/20180327134236-3                                                   
+$tmpdir/cas/20190814070007-3                                                   

 [ /org/fedorahosted/certmonger/cas/CA5: org.fedorahosted.certmonger.ca.get_nickname ]
 dogtag-ipa-renew-agent                                                         
make[1]: *** [Makefile:1089: check] Error 1

This is a wrong diff, because the expected outcomings are placed at expected.out.nodsa in this case. This file was added in https://pagure.io/certmonger/c/a22d36aed830c7ccdabffc64b539e50744212532?branch=master, but later on refactorring (https://pagure.io/certmonger/c/a1194ad04ec79091695fd4ea1533347936c22262?branch=master) wasn't updated.


Metadata Update from @rcritten:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

5 months ago

Login to comment on this ticket.

Metadata
Related Pull Requests
  • #123 Merged 6 months ago