From dc7e33314b6cfb24834049ff078e12e9243b67c1 Mon Sep 17 00:00:00 2001
From: Rob Crittenden <rcritten@redhat.com>
Date: Jun 25 2020 21:25:25 +0000
Subject: Make a Kerberos ccache if one doesn't already exist


This was embedding the logic into a conditional to set a variable
that isn't used beyond this point.

Discovered by clang.

---

diff --git a/src/submit-x.c b/src/submit-x.c
index fa81e9a..4d9dc90 100644
--- a/src/submit-x.c
+++ b/src/submit-x.c
@@ -914,9 +914,8 @@ main(int argc, const char **argv)
 
 	/* Maybe we need a ccache. */
 	if (k5 || (kpname != NULL) || (ktname != NULL)) {
-		if (!make_ccache ||
-		    (cm_submit_x_make_ccache(ktname, kpname, NULL) == 0)) {
-			k5 = TRUE;
+		if (!make_ccache) {
+		    cm_submit_x_make_ccache(ktname, kpname, NULL);
 		}
 	}