From 78fd122baa45921b8cbc53ed28fdd024187d426e Mon Sep 17 00:00:00 2001
From: Nalin Dahyabhai <nalin@dahyabhai.net>
Date: Jun 10 2014 15:37:57 +0000
Subject: Don't leak file pointers on exit (static analysis)


---

diff --git a/src/casave.c b/src/casave.c
index 4a2eaad..2d5dfd0 100644
--- a/src/casave.c
+++ b/src/casave.c
@@ -141,9 +141,11 @@ cm_casave_main_n(int fd, struct cm_store_ca *ca, struct cm_store_entry *e,
 			}
 			switch (ec) {
 			case PR_NO_ACCESS_RIGHTS_ERROR: /* EACCES or EPERM */
+				fclose(fp);
 				return CM_CERTSAVE_STATUS_PERMS;
 				break;
 			default:
+				fclose(fp);
 				return CM_CERTSAVE_STATUS_INTERNAL_ERROR;
 				break;
 			}
@@ -205,9 +207,11 @@ cm_casave_main_n(int fd, struct cm_store_ca *ca, struct cm_store_entry *e,
 		error = NSS_ShutdownContext(ctx);
 		if (error != SECSuccess) {
 			cm_log(1, "Error shutting down NSS.\n");
+			fclose(fp);
 			return CM_CERTSAVE_STATUS_INTERNAL_ERROR;
 		}
 	}
+	fclose(fp);
 	return 0;
 }
 
@@ -230,9 +234,11 @@ cm_casave_main_o(int fd, struct cm_store_ca *ca, struct cm_store_entry *e,
 			switch (errno) {
 			case EACCES:
 			case EPERM:
+				fclose(fp);
 				return CM_CERTSAVE_STATUS_PERMS;
 				break;
 			default:
+				fclose(fp);
 				return CM_CERTSAVE_STATUS_INTERNAL_ERROR;
 				break;
 			}