From 2867120b25b033d6a6e0e64dc5cb49278fa3a1b9 Mon Sep 17 00:00:00 2001
From: Jiri Konecny <jkonecny@redhat.com>
Date: Feb 17 2016 10:56:52 +0000
Subject: Do not skip evaluation after removing partitions


The on_remove_clicked() method in Custom spoke used return instead
of break. That skipped the evaluation after the for cycle with
multiselection.

Problem happens when user selects multiple mountpoints. Confirm some and
then skip others. This could set the Custom spoke to undefined behavior
because the post code is not evaluated.

---

diff --git a/pyanaconda/ui/gui/spokes/custom.py b/pyanaconda/ui/gui/spokes/custom.py
index c4ffd39..b022d7d 100644
--- a/pyanaconda/ui/gui/spokes/custom.py
+++ b/pyanaconda/ui/gui/spokes/custom.py
@@ -1977,7 +1977,7 @@ class CustomPartitioningSpoke(NormalSpoke, StorageChecker):
 
                     if rc != 1:
                         if skip_dialog:
-                            return
+                            break # skip evaluation of all other mountpoints
                         continue
 
                 if device.exists:
@@ -2001,7 +2001,7 @@ class CustomPartitioningSpoke(NormalSpoke, StorageChecker):
 
                     if rc != 1:
                         if skip_dialog:
-                            return
+                            break # skip evaluation of all other mountpoints
                         continue
 
                 if skip_dialog and not is_multiselection: