#678 dist-git "flat" layout builds failing in get_sources on c9s builders
Closed: Fixed with Explanation 4 months ago by arrfab. Opened 6 months ago by daandemeyer.

Trying to use flat layout dist-git for the hyperscale sig systemd RPM repo (git.centos.org/rpms/systemd). Stream 8 builds correctly but Stream 9 fails to build the SRPM (https://cbs.centos.org/koji/taskinfo?taskID=2704358). The failure seems to be in get_sources.sh (looking at https://cbs.centos.org/kojifiles/work/tasks/4359/2704359/root.log).

Branch in the RPM repo triggering this is c9s-sig-hyperscale. Build command is cbs build hyperscale9s-packages-main-el9s "git+https://git.centos.org/rpms/systemd.git#$(git rev-parse HEAD)"


Metadata Update from @bstinson:
- Issue assigned to bstinson

6 months ago

Metadata Update from @zlopez:
- Issue tagged with: centos-stream

6 months ago

Same issue for me for rpm and centos-stream-spin-hyperscale-release

So the error for centos-stream-spin-hyperscale-release is due to the fact that the sources file is empty while the code expect it to not be empty when using flat layout: https://git.centos.org/centos-git-common/blob/ae9a7e62f921a4e456e9039c6b8f83434111ff61/f/get_sources.sh#_149

I am not able to reproduce the error on either rpm or systemd, running get_sources.sh works for me on both :(

Wild guess: set -eu at https://git.centos.org/centos-git-common/blob/ae9a7e62f921a4e456e9039c6b8f83434111ff61/f/get_sources.sh#_12 may be biting us. It wasn't there before and while it's present in Fedora maybe it's blocking us now.

reminder that the problem is that for 9s (and with normal inheritance) a newer centpkg-minimal pkg should be built to replace https://kojihub.stream.centos.org/koji/packageinfo?packageID=1.
Once it will be in centos9s-buildroot , it will be available for SIG having asked for that repo to be enabled, and so they'll get newer get_sources.sh

Ah, I had missed Fabian's comment, so if C9S isn't using that version of the script that explains :)

I'll drop the commit which removes set -eu from the PR as I think it's useful to keep it and we now know it's not the root cause :)

The version of centpkg-minimal used in CBS isn't in CBS. It is using v2.1.0 while the latest built in CBS is v2.0.0.

Anyway, can we please get the centos-git-common stuff merged and released?

DEBUG util.py:446:   centpkg-minimal              noarch  2.1.0-2.cs9                  build   11 k

That's in our build envs now.

I've worked around it with a new centpkg-minimal build: https://cbs.centos.org/koji/buildinfo?buildID=37949

I hope that we can get this fixed for all SIGs soon, though.

I just hit this yesterday again when trying to build compsize for hyperscale8s-packages-experimental-el8: https://cbs.centos.org/koji/taskinfo?taskID=2765957

@dcavalca well, it's because someone in your SIG tagged a specific centpkg-minimal pkg that doesn't match the one we have for all SIGs :

what whould be inherited

cbs list-tagged buildsys8s-release
Build                                     Tag                   Built by
----------------------------------------  --------------------  ----------------
buildsys-macros-el8s-1.0-1.el8            buildsys8s-release    cbs-koji
centpkg-minimal-2.0.0-2.el8s              buildsys8s-release    bstinson
centpkg-minimal-2.0.0-4.el8s              buildsys8s-release    cbs-koji
centpkg-minimal-2.1.0-5.el8s              buildsys8s-release    cbs-koji

What there is in that build tag:

cbs list-tagged hyperscale8s-packages-experimental-el8-build
Build                                     Tag                   Built by
----------------------------------------  --------------------  ----------------
centpkg-minimal-2.0.0-2.el8               hyperscale8s-packages-experimental-el8-build  bstinson

So because it has priority in the build tag, it's pulling that version (see root.log from your task) and not the one from buildsys8s-release

I've removed the one that was added to your build tag

cbs untag-build hyperscale8s-packages-experimental-el8-build centpkg-minimal-2.0.0-2.el8 && cbs regen-repo hyperscale8s-packages-experimental-el8-build 

From the createrepo.log I can see that the one we built (and that all SIGs should inherit) was added :
06:47:34: Adding pkg: /mnt/koji/repos/hyperscale8s-packages-experimental-el8-build/905377/x86_64/toplink/packages/centpkg-minimal/2.1.0/5.el8s/noarch/centpkg-minimal-2.1.0-5.el8s.noarch.rpm

Then resubmitted that task and it's now working : https://cbs.centos.org/koji/taskinfo?taskID=2769267

So worth reminding that tagging in your own tag a pkg that is also coming from buildsys{8s,9s} would mean that you don't inherit anymore when we push a newer version there, as your own tag as higher priority ;-)

BTW, realizing that this ticket can be closed as it's also fixed for centos9s :

cbs list-tagged buildsys9s-release
Build                                     Tag                   Built by
----------------------------------------  --------------------  ----------------
buildsys-macros-el9s-1.0-2.el9            buildsys9s-release    cbs-koji
centpkg-minimal-2.0.0-3.el9               buildsys9s-release    cbs-koji
centpkg-minimal-2.0.0-4.el9s              buildsys9s-release    arrfab
centpkg-minimal-2.1.0-5.el9               buildsys9s-release    cbs-koji

Don't think it was already rebuilt on distro builders but it's available through buildsys9s-release (and ideally tags using centos9s-buildroot would get it from buildsys9s-release, but was confirmed to be working for automotive SIG : https://pagure.io/centos-infra/issue/645

So closing this one, even if that would still be good to ensure that same version is available through centos9s-buildroot but so different builders

Metadata Update from @arrfab:
- Issue tagged with: cbs, high-gain, medium-trouble

4 months ago

Metadata Update from @arrfab:
- Issue close_status updated to: Fixed with Explanation
- Issue status updated to: Closed (was: Open)

4 months ago

Login to comment on this ticket.

Metadata
Boards 1
CBS Status: Backlog