I would like to ask for new targets and tags (el7 only, all available arches) for the following collections:
devtoolset-11
devtoolset-10
rh-nginx120
rh-perl530
rh-redis6
Last time we did this, there were some issues with the minimal buildroot(s) – see #165 and #180 for reference. Hopefully the creation script is now fixed, but to be on the safe side: the minimal buildroot needs to have the following two packages installed by default:
scl-utils-build
{collection}-build
rh-nginx120-build
Metadata Update from @arrfab: - Issue assigned to arrfab
Metadata Update from @arrfab: - Issue tagged with: cbs, medium-gain, medium-trouble
Started to work on in and I'll also work on the automation script to test that for SCLo tags, we'll ensure that it's also automatically added, including for the specific sclo7-all-rh-release that uses tag-inheritance when composing the full tree before pushing it out
Can you have a look and see if all looks sane for SCL builds ?
/opt/cbs-tools/scripts/create_sig.sh -a "x86_64 ppc64le aarch64" -s sclo -d 7 -p devtoolset-11 -r rh -t el7 * Checking distribution el7 configuration... -> Checking sclo config... Using default options for sclo/devtoolset-11 Creating tag : sclo7-devtoolset-11-rh-candidate Creating tag : sclo7-devtoolset-11-rh-testing Creating tag : sclo7-devtoolset-11-rh-release -> creating sclo7-devtoolset-11-rh-el7 Added external repo centos7-cr to tag sclo7-devtoolset-11-rh-el7-build (priority 5) Added external repo centos7-extras to tag sclo7-devtoolset-11-rh-el7-build (priority 10) Added external repo centos7-updates to tag sclo7-devtoolset-11-rh-el7-build (priority 15) Added external repo centos7-os to tag sclo7-devtoolset-11-rh-el7-build (priority 20) Adding sclo7-common-candidate as inheritance koji add-tag-inheritance sclo7-devtoolset-11-rh-el7-build sclo7-devtoolset-10-rh-candidate
/opt/cbs-tools/scripts/create_sig.sh -a "x86_64 ppc64le aarch64" -s sclo -d 7 -p rh-nginx120 -r rh -t el7 * Checking distribution el7 configuration... -> Checking sclo config... Using default options for sclo/rh-nginx120 Creating tag : sclo7-rh-nginx120-rh-candidate Creating tag : sclo7-rh-nginx120-rh-testing Creating tag : sclo7-rh-nginx120-rh-release -> creating sclo7-rh-nginx120-rh-el7 Added external repo centos7-cr to tag sclo7-rh-nginx120-rh-el7-build (priority 5) Added external repo centos7-extras to tag sclo7-rh-nginx120-rh-el7-build (priority 10) Added external repo centos7-updates to tag sclo7-rh-nginx120-rh-el7-build (priority 15) Added external repo centos7-os to tag sclo7-rh-nginx120-rh-el7-build (priority 20) Adding sclo7-common-candidate as inheritance koji add-tag-inheritance sclo7-rh-nginx120-rh-el7-build sclo7-rh-perl530-rh-el7-build
/opt/cbs-tools/scripts/create_sig.sh -a "x86_64 ppc64le aarch64" -s sclo -d 7 -p rh-redis6 -r rh -t el7 * Checking distribution el7 configuration... -> Checking sclo config... Using default options for sclo/rh-redis6 Creating tag : sclo7-rh-redis6-rh-candidate Creating tag : sclo7-rh-redis6-rh-testing Creating tag : sclo7-rh-redis6-rh-release -> creating sclo7-rh-redis6-rh-el7 Added external repo centos7-cr to tag sclo7-rh-redis6-rh-el7-build (priority 5) Added external repo centos7-extras to tag sclo7-rh-redis6-rh-el7-build (priority 10) Added external repo centos7-updates to tag sclo7-rh-redis6-rh-el7-build (priority 15) Added external repo centos7-os to tag sclo7-rh-redis6-rh-el7-build (priority 20) Adding sclo7-common-candidate as inheritance
the scl-utils-build and ${collection}-build pkg were also added in the -build group. Waiting on your feedback and then it will be also all documented for SCL if someone needs to proceed with tags for SCLo sigs
${collection}-build
Metadata Update from @arrfab: - Issue priority set to: Waiting on Reporter (was: Needs Review)
The inheritances are wrong: The -candidate tag of the dependency should be included, not the -build one. For example:
-candidate
-build
koji add-tag-inheritance sclo7-rh-nginx120-rh-el7-build sclo7-rh-perl530-rh-el7-build
koji add-tag-inheritance sclo7-rh-nginx120-rh-el7-build sclo7-rh-perl530-rh-el7-candidate
The reason for this is the ${collection}-build packages. If that package is installed, the scl macros expand in a way that makes the subsequent package builds produce ${collection} packages. When you inherit -build tag, you essentially have two of those ${collection}-build packages in the buildroot, and a sort of "cross-polination" can happen.
${collection}
My testing build fail shows exactly that:
BuildError: package rh-perl530-nginx not in list for tag sclo7-rh-nginx120-rh-candidate
No package rh-perl530-nginx should exists, it should be rh-nginx120-nginx. This is the result of also having rh-perl530-build in the buildroot (via inheritance from the perl tags) and that getting a priority. (Note: that priority is AFAIK non-deterministic, but still.)
rh-perl530-nginx
rh-nginx120-nginx
rh-perl530-build
oh, yeah, realizing that it was done correctly for devtoolset but not for nginx120. Should be ok now :100:
koji taginfo sclo7-rh-nginx120-rh-el7-build Tag: sclo7-rh-nginx120-rh-el7-build [2504] Arches: x86_64 ppc64le aarch64 Groups: build, srpm-build Tag options: This tag is a buildroot for one or more targets Current repo: repo#862377: 2021-10-18 08:26:02.302375+00:00 Targets that build from this tag: sclo7-rh-nginx120-rh-el7 External repos: 5 centos7-cr (http://mirror.centos.org/centos/7/cr/$arch/, merge mode: koji), arches: inherited from tag 10 centos7-extras (http://mirror.centos.org/centos/7/extras/$arch/, merge mode: koji), arches: inherited from tag 15 centos7-updates (http://mirror.centos.org/centos/7/updates/$arch/, merge mode: koji), arches: inherited from tag 20 centos7-os (http://mirror.centos.org/centos/7/os/$arch/, merge mode: koji), arches: inherited from tag Inheritance: 0 .... sclo7-rh-perl530-rh-candidate [2065] 5 .... buildsys7 [6] 10 .... sclo7-rh-nginx120-rh-candidate [2501] 20 .... sclo7-common-candidate [183]
BTW, wondering if we should have a template in this tracker for a cbs tag request and asking in each the full tag (instead of just something like rh-nginx120, which should also inherit from rh-perl530 )
rh-nginx120, which should also inherit from rh-perl530
Let me know if that works for you now
That was the way we have done it before moving to pagure/centos-infra. Then it seemed that you would do the right thing anyway, so I got lazy :sweat_smile: I will try to remember to use the full tag specification in the future.
Seems to be building right now: https://cbs.centos.org/koji/taskinfo?taskID=2576800, so :tada:
I will try devtoolset-11 next, but that will take longer to complete.
Cool, so based on koji taginfo, it should be also be working for devtoolset-11 .. let me close this ticket but feel free to reopen it in case you'd have issues with it
Metadata Update from @arrfab: - Issue close_status updated to: Fixed with Explanation - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.