As discussed with @arrfab at Dojo, we'd like to add another tag:
$sig = hyperscale $version = 8s $project = packages $version = facebook
leading to: hyperscale8s-packages-facebook-{candidate,testing,release}
Akin to https://pagure.io/centos-infra/issue/211, this should have a custom disttag of %dist .fb.el8. Additionally, we'd like the %facebook 1 macro to be set in the buildroot.
%dist .fb.el8
%facebook 1
Oh and like the others, we only need this for x86_64 for now. Thanks!
x86_64
I think it would be nicer to have .hs+fb.el8 or something like that so that it is visible that package coming from hyperscale sig with Facebook flavor.
+1, I like that much better actually
Metadata Update from @arrfab: - Issue marked as depending on: #211 - Issue tagged with: cbs, low-gain, medium-trouble
Metadata Update from @arrfab: - Issue assigned to arrfab
Created :
* Checking distribution el8s configuration... -> Checking hyperscale config... Using default options for hyperscale/packages Creating tag : hyperscale8s-packages-facebook-candidate Creating tag : hyperscale8s-packages-facebook-testing Creating tag : hyperscale8s-packages-facebook-release -> creating hyperscale8s-packages-facebook-el8 Added external repo centos8s-cr to tag hyperscale8s-packages-facebook-el8-build (priority 5) Added external repo centos8s-extras to tag hyperscale8s-packages-facebook-el8-build (priority 10) Added external repo centos8s-powertools to tag hyperscale8s-packages-facebook-el8-build (priority 15) Added external repo centos8s-appstream to tag hyperscale8s-packages-facebook-el8-build (priority 20) Added external repo centos8s-baseos to tag hyperscale8s-packages-facebook-el8-build (priority 25)
Also added different dist tag:
Tag: hyperscale8s-packages-facebook-el8-build [2254] Arches: x86_64 Groups: build, srpm-build Tag options: mock.new_chroot : 1 mock.package_manager : 'dnf' rpm.macro.dist : '.hs+fb.el8' rpm.macro.facebook : 1
Can you give feedback and I'll close it ?
Metadata Update from @arrfab: - Issue priority set to: Waiting on Reporter (was: Needs Review)
Yep, I think we're good to go: https://cbs.centos.org/koji/taskinfo?taskID=1934288 Thanks again!
One question though: I did a real build and tagged -testing, and it ended up at https://buildlogs.centos.org/centos/8-stream/hyperscale/x86_64/packages-facebook/ and the one for main at https://buildlogs.centos.org/centos/8-stream/hyperscale/x86_64/packages-main/
Is this correct? I'd have expected to get /packages/main/ and /packages/facebook/ (as "main" and "facebook" are the $version here).
/packages/main/
/packages/facebook/
Likewise for experimental, I haven't built one there yet but I'd expect it to end up at /packages/experimental/
/packages/experimental/
the packages-main and packages-facebook directories are automatically computed from the koji tags, and so that's where they were supposed to land. There is no specific config for the signing and push process, just using the koji tags in the following format <centos_release>/<SIG>/<arch>/<project>-<version> (see https://wiki.centos.org/SIGGuide#SIGGuide.2FContent.2FBuild.Short_detour_to_describe_Tags_and_Targets) and all SIGs are following the same rule (as signing process it following that tag structure to know what to sign and push where)
Got it, thanks!
As the tag is ok and macro/build, let me close it
Metadata Update from @arrfab: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.