To ensure NVRs are always unique and make package attribution clearer, we'd like to set a custom disttag for our tags. Specifically: - for hyperscale8s-packages-main-*, set %dist .hs.el8 - for hyperscale8s-packages-experimental-*, set %dist .hsx.el8
hyperscale8s-packages-main-*
%dist .hs.el8
hyperscale8s-packages-experimental-*
%dist .hsx.el8
cc @ngompa who originally suggested this
Tagging @alphacc as it's more complex that it looks Koji by default doesn't easily do that per tag or settings : https://pagure.io/koji/issue/276
So we need now to have a specific pkg just for you and each dist tag you request (nobody from other SIG ever asked for that) .. So that will have to wait a little bit and some way to formalize such process easily
Metadata Update from @arrfab: - Issue tagged with: cbs, low-gain, medium-trouble
I suppose we can just add .hs to Release in our specfiles as a temporary stopgap, and then drop it once there's a good solution for this. If we do need to maintain a package per disttag that should be fine (albeit a bit cumbersome for sure).
.hs
Release
@arrfab 8 think that bug is obsolete. You can set RPM macro on the tag basis. FWIW Koji edit-tag -x rpm.macro.tag=...
@ignatenkobrain thanks we can give it a try, so that would become rpm.macro.dist='.hs.el8' (for first case) ? I thought it would come through mock. options but let's give it a try :)
@arrfab try koji edit-tag hyperscale8s-packages-main-el8-build -x rpm.macro.dist='.hs.el8', yes.
koji edit-tag hyperscale8s-packages-main-el8-build -x rpm.macro.dist='.hs.el8'
Metadata Update from @arrfab: - Issue assigned to arrfab
can you confirm that it looks ok ?
Tag: hyperscale8s-packages-main-el8-build [2250] Arches: x86_64 Groups: build, srpm-build Tag options: mock.package_manager : 'dnf' rpm.macro.dist : '.hs.el8' rpm.macro.facebook : 1 Tag: hyperscale8s-packages-experimental-el8-build [2246] Arches: x86_64 Groups: build, srpm-build Tag options: mock.package_manager : 'dnf' rpm.macro.dist : '.hsx.el8' rpm.macro.facebook : 1
FWIW, I just tested a scratch build (from git and for time pkg) and and produced rpm has the .hsx.el8 dist tag : https://cbs.centos.org/koji/taskinfo?taskID=1934004
Just waiting for feedback and I'll close ticket after
Metadata Update from @arrfab: - Issue priority set to: Waiting on Reporter (was: Needs Review)
@arrfab facebook macro should not be set on non-fb tags.
@ignatenkobrain yes, and believe me or not, but I was just removing it after I compared the two tickets, so should be ok now .. that's what happens when one tries to do that on a sunday :)
Yep, this looks good to me, see https://cbs.centos.org/koji/taskinfo?taskID=1934285 Thanks!
Metadata Update from @arrfab: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.