#1153 Driver Discs created for user space packages
Closed: Fixed 11 months ago by pjgeorg. Opened 11 months ago by pjgeorg.

I just realized that currently "Driver Discs" are also created for user space packages, see 1 and 2. But it probably affects all build targets.

The functionality has been implemented in #418 and my understanding was that it only applies to packages named kmod-*. However it seems to be applied to all packages named k*.

In case the creation of Driver Discs is only enabled on a tag/build target basis, it can also simply be disabled for kmods*-packages-userspace.


Metadata Update from @arrfab:
- Issue assigned to arrfab
- Issue tagged with: cbs, medium-gain, medium-trouble

11 months ago

ack ... the function called to produce DuD .iso images was written under assumption that kmod SIG would only build kmod rpms :) .. I'll modify and test a modified function to verify first if it's really a kmod*.rpm or else (userspace).
I hope to have something in the next hours/days

I implemented extra check and it should skip non kmod*.rpm to generate .iso.
I tested for -testing tag and it deleted automatically DriverDiscs files/folder.
I then kicked it again manually for -release and confirm through the log:

deleting DriverDiscs/kafs-client-libs-devel-0.4-4.el9.x86_64.iso
deleting DriverDiscs/kafs-client-libs-debuginfo-0.4-4.el9.x86_64.iso
deleting DriverDiscs/kafs-client-libs-0.4-4.el9.x86_64.iso
deleting DriverDiscs/kafs-client-debugsource-0.4-4.el9.x86_64.iso
deleting DriverDiscs/kafs-client-debuginfo-0.4-4.el9.x86_64.iso
deleting DriverDiscs/kafs-client-compat-0.4-4.el9.x86_64.iso
deleting DriverDiscs/kafs-client-0.4-4.el9.x86_64.iso
deleting DriverDiscs/

So I think I can now close this one and it will be automatically cleaning out .iso images that shouldn't be there when you'll tag build something for -testing or -release

Can you confirm it's all good for you and then close ticket ?

Metadata Update from @arrfab:
- Issue priority set to: Waiting on Reporter (was: Needs Review)

11 months ago

All looks good to me. Thanks!

Metadata Update from @pjgeorg:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

11 months ago

Login to comment on this ticket.