#196 Include config.h in all files using LIBDNS_VERSION_MAJOR
Merged 7 months ago by abbra. Opened 7 months ago by pemensik.
pemensik/bind-dyndb-ldap master  into  master

file modified
+1
@@ -8,6 +8,7 @@ 

  #include <dns/zone.h>

  #include <dns/zt.h>

  

+ #include "config.h"

  #include "empty_zones.h"

  #include "util.h"

  #include "zone_register.h"

file modified
+1
@@ -20,6 +20,7 @@ 

  #include <strings.h>

  #include <ctype.h>

  

+ #include "config.h"

  #include "str.h"

  #include "ldap_convert.h"

  #include "log.h"

file modified
+1
@@ -18,6 +18,7 @@ 

  #include <dns/zone.h>

  #include <dns/zt.h>

  

+ #include "config.h"

  #include "util.h"

  #include "ldap_convert.h"

  #include "ldap_entry.h"

Did not know compiler replaces unknown symbols with 0. It made the check
silently evaluate to false on every BIND version, regardless detected
libdns version number. Generated code failing runtime with BIND 9.16.

Signed-off-by: Petr Menšík pemensik@redhat.com

Fixes #195

LGTM. After compilation, dns_name_copynf symbols are in use where expected:

for i in src/.libs/ldap_la-*.o ; do echo $i && (nm $i|grep dns_name_copynf) ; done
src/.libs/ldap_la-acl.o
src/.libs/ldap_la-bindcfg.o
src/.libs/ldap_la-empty_zones.o
                 U dns_name_copynf
src/.libs/ldap_la-fs.o
src/.libs/ldap_la-fwd.o
src/.libs/ldap_la-fwd_register.o
src/.libs/ldap_la-krb5_helper.o
src/.libs/ldap_la-ldap_convert.o
                 U dns_name_copynf
src/.libs/ldap_la-ldap_driver.o
src/.libs/ldap_la-ldap_entry.o
src/.libs/ldap_la-ldap_helper.o
src/.libs/ldap_la-lock.o
src/.libs/ldap_la-log.o
src/.libs/ldap_la-metadb.o
src/.libs/ldap_la-mldap.o
                 U dns_name_copynf
src/.libs/ldap_la-rbt_helper.o
src/.libs/ldap_la-semaphore.o
src/.libs/ldap_la-settings.o
src/.libs/ldap_la-str.o
src/.libs/ldap_la-syncptr.o
                 U dns_name_copynf
src/.libs/ldap_la-syncrepl.o
src/.libs/ldap_la-zone.o
src/.libs/ldap_la-zone_register.o

Pull-Request has been merged by abbra

7 months ago