PR#17: basset-worker: Pika's Channel#basic_consume's parameter order changed - basset

basset

#17 basset-worker: Pika's Channel#basic_consume's parameter order changed

Closed 3 years ago by abompard. Opened 4 years ago by codeblock.

codeblock/basset master into master

basset-worker: Pika's Channel#basic_consume's parameter order changed

Rick Elrod • 4 years ago

930c0d9

basset-worker

file modified

+1 -2

		`@@ -141,8 +141,7 @@`

		`# Make sure we leave any other messages in the queue`
		`channel.basic_qos(prefetch_count=1)`
		`- channel.basic_consume(callback,`
		`- queue='check_submission')`
		`+ channel.basic_consume('check_submission', callback)`

		`try:`
		`log.debug('Starting consuming')`

codeblock commented 4 years ago

Signed-off-by: Rick Elrod rick@elrod.me

puiterwijk commented 4 years ago

If they changed the order, could we instead of going with the implicit order of both arguments, just go explicit on both of them, so the code works with both old and new versions?

codeblock commented 4 years ago

Possibly? The original error was complaining about a duplicate queue parameter. If I name both arguments of the function call will it appease python?