Per mailing list:
"Are there any guidelines or policies for what to put in the "install" or "uninstall" labels in my Dockerfiles? Can images basically do whatever they want in those scripts?
I see examples where the install script sets up systemd unit files - is that the pattern these install shell scripts should always follow?
I also saw an example where an image provides "LABEL install" but no "LABEL uninstall". Is that bad?"
We need to add some examples and details for these labels.
Metadata Update from @jberkus: - Issue tagged with: VFAD
Metadata Update from @jberkus: - Issue tagged with: containers
Metadata Update from @jberkus: - Issue untagged with: VFAD - Issue set to the milestone: 2017-03-10 VFAD
Metadata Update from @jberkus: - Issue assigned to dustymabe
Update from VFAD:
The INSTALL and UNINSTALL labels are optional. They are only recommended if the container needs some kind of setup beyond "pull". System containers probably always need them. If an INSTALL is supplied, and UNINSTALL should be as well. Both of these labels should work, and should be tested using the Atomic CLI. Guidelines for Install/Uninstall will be included, but mostly point to the Atomic CLI docs.
Clarification in Container Guidelines in progress.
Updated guidelines: https://fedoraproject.org/wiki/Container:Guidelines#LABEL_SPECIFICATION
@jberkus, please ratify and then close this ticket.
Doesn't contain the guidelines outlined above in this issue, or any examples. Needs more detail.
updated, check again
Looks good. Closing this, since I don't believe we need to notify maintainers specifically of this change.
Metadata Update from @jberkus: - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.