#82 libre/discover without nonfree webview support and TPPM functionality
Closed 9 months ago by solvefinder. Opened 10 months ago by solvefinder.
solvefinder/abslibre discover  into  pull-requests

@@ -0,0 +1,50 @@ 

+ # Maintainer: Antonio Rojas <arojas@archlinux.org> 

+ 

+ pkgname=discoverless

+ _pkgname=discover

+ pkgver=5.27.7

+ _dirver=$(echo $pkgver | cut -d. -f1-3)

+ pkgrel=1

+ pkgrel+=.parabola1

+ pkgdesc='KDE and Plasma resources management GUI'

+ pkgdesc+=', without non-free webview support and TPPM functionality'

+ arch=(x86_64)

+ arch+=(i686 armv7h)

+ url='https://kde.org/plasma-desktop/'

+ license=(LGPL)

+ depends=(kidletime

+          qt5-graphicaleffects

+          appstream-qt

+          # parabola-appstream-data

+          kirigami2

+          discount

+          kuserfeedback

+          purpose)

+ makedepends=(extra-cmake-modules plasma-framework packagekit-qt5)

+ optdepends=('packagekit-qt5: to manage packages from Parabola repositories (not recommended, use at your own risk)')

+ groups=(plasma)

+ source=(https://download.kde.org/stable/plasma/$_dirver/$_pkgname-$pkgver.tar.xz{,.sig}

+         'libre.patch')

+ sha256sums=('a9eca14bb4cf3094d5c4df7975f1a793fca8fb4018ca1252d1e1230c79784500'

+             'SKIP'

+             '6815271bf4917400f3df7fc2caf00e48099b92d22dfd8b5c3546cd36e27696a3')

+ validpgpkeys=('E0A3EB202F8E57528E13E72FD7574483BB57B18D'  # Jonathan Esk-Riddell <jr@jriddell.org>

+               '0AAC775BB6437A8D9AF7A3ACFE0784117FBCE11D'  # Bhushan Shah <bshah@kde.org>

+               'D07BD8662C56CB291B316EB2F5675605C74E02CF'  # David Edmundson <davidedmundson@kde.org>

+               '1FA881591C26B276D7A5518EEAAF29B42A678C20') # Marco Martin <notmart@gmail.com>

+ 

+ prepare() {

+   cd "$_pkgname-$pkgver"

+   patch -p1 -i ../libre.patch

+ }

+ 

+ build() {

+   cmake -B build -S $_pkgname-$pkgver \

+     -DCMAKE_INSTALL_LIBEXECDIR=lib \

+     -DBUILD_TESTING=OFF

+   cmake --build build

+ }

+ 

+ package() {

+   DESTDIR="$pkgdir" cmake --install build

+ }

@@ -0,0 +1,123 @@ 

+ From b0b3e5a09d0dcee1cafbf25462d9289892a13532 Mon Sep 17 00:00:00 2001

+ From: SolveFinder <kwopleq@proton.me>

+ Date: Fri, 4 Aug 2023 21:37:44 +0300

+ Subject: [PATCH] libre/discover without TPPM functionality; webview, flatpak, snap, fwupd and rpm-ostree support

+ 

+ ---

+  CMakeLists.txt                                |  1 -

+  discover/CMakeLists.txt                       |  7 +---

+  libdiscover/backends/CMakeLists.txt           |  8 ++---

+  .../packagekit-backend-categories.xml         | 34 -------------------

+  4 files changed, 5 insertions(+), 45 deletions(-)

+ 

+ diff --git a/CMakeLists.txt b/CMakeLists.txt

+ index f96e83b..57991ca 100644

+ --- a/CMakeLists.txt

+ +++ b/CMakeLists.txt

+ @@ -23,7 +23,6 @@ include(ECMQtDeclareLoggingCategory)

+  include(KDEClangFormat)

+  include(KDEGitCommitHooks)

+  find_package(Qt${QT_MAJOR_VERSION} ${QT_MIN_VERSION} REQUIRED CONFIG COMPONENTS Widgets Test Network Concurrent DBus Quick)

+ -find_package(Qt${QT_MAJOR_VERSION} ${QT_MIN_VERSION} CONFIG OPTIONAL_COMPONENTS WebView)

+  

+  find_package(PkgConfig REQUIRED)

+  

+ diff --git a/discover/CMakeLists.txt b/discover/CMakeLists.txt

+ index 17ac7f8..cbc2403 100644

+ --- a/discover/CMakeLists.txt

+ +++ b/discover/CMakeLists.txt

+ @@ -53,12 +53,7 @@ target_link_libraries(plasma-discover PUBLIC

+                                       Discover::Common

+  )

+  

+ -if (TARGET Qt::WebView)

+ -    target_link_libraries(plasma-discover PUBLIC Qt::WebView)

+ -    target_compile_definitions(plasma-discover PUBLIC -DWITH_QTWEBVIEW=1)

+ -else()

+ -    target_compile_definitions(plasma-discover PUBLIC -DWITH_QTWEBVIEW=0)

+ -endif()

+ +target_compile_definitions(plasma-discover PUBLIC -DWITH_QTWEBVIEW=0)

+  

+  if (TARGET KUserFeedbackCore)

+      target_link_libraries(plasma-discover PRIVATE KUserFeedbackCore)

+ diff --git a/libdiscover/backends/CMakeLists.txt b/libdiscover/backends/CMakeLists.txt

+ index bd3a032..3b40c41 100644

+ --- a/libdiscover/backends/CMakeLists.txt

+ +++ b/libdiscover/backends/CMakeLists.txt

+ @@ -21,7 +21,7 @@ if(BUILD_DummyBackend)

+      add_subdirectory(DummyBackend)

+  endif()

+  

+ -option(BUILD_FlatpakBackend "Build Flatpak support" "ON")

+ +option(BUILD_FlatpakBackend "Build Flatpak support" "OFF")

+  if(Flatpak_FOUND AND AppStreamQt_FOUND AND BUILD_FlatpakBackend)

+      add_subdirectory(FlatpakBackend)

+  elseif(BUILD_FlatpakBackend)

+ @@ -40,17 +40,17 @@ if(BUILD_SteamOSBackend)

+      add_subdirectory(SteamOSBackend)

+  endif()

+  

+ -option(BUILD_SnapBackend "Build Snap support." "ON")

+ +option(BUILD_SnapBackend "Build Snap support." "OFF")

+  if(BUILD_SnapBackend AND AppStreamQt_FOUND AND Snapd_FOUND)

+      add_subdirectory(SnapBackend)

+  endif()

+  

+ -option(BUILD_FwupdBackend "Build Fwupd support." "ON")

+ +option(BUILD_FwupdBackend "Build Fwupd support." "OFF")

+  if(BUILD_FwupdBackend AND TARGET PkgConfig::Fwupd)

+      add_subdirectory(FwupdBackend)

+  endif()

+  

+ -option(BUILD_RpmOstreeBackend "Build rpm-ostree support." "ON")

+ +option(BUILD_RpmOstreeBackend "Build rpm-ostree support." "OFF")

+  if(BUILD_RpmOstreeBackend AND Ostree_FOUND AND RpmOstree_FOUND)

+      add_subdirectory(RpmOstreeBackend)

+  endif()

+ diff --git a/libdiscover/backends/PackageKitBackend/packagekit-backend-categories.xml b/libdiscover/backends/PackageKitBackend/packagekit-backend-categories.xml

+ index ff1a922..f6b5fe3 100644

+ --- a/libdiscover/backends/PackageKitBackend/packagekit-backend-categories.xml

+ +++ b/libdiscover/backends/PackageKitBackend/packagekit-backend-categories.xml

+ @@ -548,39 +548,5 @@

+        </Or>

+      </Include>

+    </Menu>

+ -  <Menu>

+ -    <Name>Plasma Addons</Name>

+ -    <Icon>plasma</Icon>

+ -    <Addons />

+ -

+ -    <Include>

+ -        <Or>

+ -            <AppstreamIdWildcard>org.kde.plasma.*</AppstreamIdWildcard>

+ -        </Or>

+ -    </Include>

+ -

+ -    <Menu>

+ -      <Name>Plasma Widgets</Name>

+ -      <Icon>plasma</Icon>

+ -      <Addons />

+ -      <Include>

+ -        <Or>

+ -            <AppstreamIdWildcard>org.kde.plasma.*</AppstreamIdWildcard>

+ -        </Or>

+ -      </Include>

+ -    </Menu>

+ -

+ -<!--

+ -    <Menu>

+ -      <Name>Fonts</Name>

+ -      <Icon>preferences-desktop-font</Icon>

+ -      <Include>

+ -        <And>

+ -            <Category>Fonts</Category>

+ -        </And>

+ -      </Include>

+ -    </Menu>

+ --->

+ -  </Menu>

+  

+  </Menu>

+ -- 

+ 2.41.0

+ 

This commit removes webview support and TPPM functionality from discover.
"libre.patch" removes webview support.
Without "knewstuff" in "depends" Plasma-related functionality won't be compiled.

pkgname=discoverless
...
# parabola-appstream-data

^
|
These changes for the ability to compile using libremakepkg when there's no libre version of discover in "blacklist.txt"
If everything is fine with package, pkgname should be "discover" and "parabola-appstream-data" should be in depends

If there's something wrong with this patch that could be fixed - I'd try to fix it

Original PKGBUILD: "https://gitlab.archlinux.org/archlinux/packaging/packages/discover/-/blob/main/PKGBUILD"

depends on PR #78

like i noted on #78, it is not obvious if we can use them, or what is their value if all they can do is install the same packages that pacman can - we should discuss this on the bug tracker or mailing list

https://labs.parabola.nu/issues/1413

1 new commit added

  • Update libre/discover/libre.patch according to message from dev mailing list
9 months ago

1 new commit added

  • Update libre/discover/PKGBUILD according to message from dev mailing list
9 months ago

Pull-Request has been closed by solvefinder

9 months ago