#26 remove missed nonfree icons in faenza and faience icon theme
Opened 2 months ago by dikasp. Modified 2 months ago
dikasp/abslibre pull-requests  into  pull-requests

@@ -7,11 +7,12 @@ 

  # Maintainer: André Silva <emulatorman@hyperbola.info>

  # Contributor: Jorge Araya Navarro <elcorreo@deshackra.com>

  # Contributor: Márcio Silva <coadde@hyperbola.info>

+ # Contributor: dikasp <dikasetyaprayogi@gmail.com>

  

  pkgname=faenza-icon-theme

  pkgver=1.3.1

  pkgrel=5

- pkgrel+=.par1

+ pkgrel+=.par2

  pkgdesc='Icon theme designed for Equinox GTK theme'

  pkgdesc+=', without nonfree distros and application icons (Parabola rebranded)'

  url='http://gnome-look.org/content/show.php/Faenza?content=128143'
@@ -33,7 +34,7 @@ 

   rm -rv debian

  

   # remove nonfree distros and application logos

-  for nonfree in archlinux debian fedora frugalware gentoo linux-mint mandriva opensuse redhat slackware ubuntu flash rpmdrake novell skype; do

+  for nonfree in adobe-air AdobeAIR AdobeReader AdobeReader8 AdobeReader9 AdobeReader10 acroread amazon-mp3-store-source amazon-store as-icon as-powered autoplus archlinux checkgmail chromium chromium-browser chromium-browser2 debian defcon easylife evernote facebook fedora firefox firefox-3.0 firefox-3.5 firefox-4.0 firefox-original flash frugalware gentoo gmail gmailwatcher goa-account-facebook goa-account-google goa-account-twitter goa-account-yahoo google google-chrome google-chrome2 google-chrome-unstable google-earth googleearth googlemusicframe google-plus gtwitter last-fm lastfm-audioscrobbler linux-mint mandriva mendeley mendeleydesktop nixnote novell opensuse opera opera-browser opera-widget opera-widget-manager picasa picasa32x32 picasa-fontcfg redhat rpmdrake skype slackware susehelpcenter twitter Twitter-twitter.com ubuntu yahoo youtube; do

    find -name *$nonfree* -delete

   done

  
@@ -85,4 +86,4 @@ 

        ln -sf gnome-session-reboot.png system-reboot.png

      done

    done

- }

+ } 

\ No newline at end of file

@@ -6,10 +6,11 @@ 

  # Contributor (Hyperbola): Márcio Silva <coadde@hyperbola.info>

  # Maintainer: Omar Vega Ramos <ovruni@gnu.org.pe>

  # Contributor: Jorge Araya Navarro <elcorreo@deshackra.com>

+ # Contributor: dikasp <dikasetyaprayogi@gmail.com>

  

  pkgname=faience-icon-theme

  pkgver=0.5.1

- pkgrel=3.parabola2

+ pkgrel=3.parabola3

  pkgdesc='An icon theme based on Faenza, without nonfree distros and application icons (Parabola rebranded)'

  url='http://tiheum.deviantart.com/art/Faience-icon-theme-255099649'

  license=('GPL3')
@@ -27,7 +28,7 @@ 

    rm -rv debian

  

    # remove nonfree distros and application logos

-   for nonfree in archlinux debian fedora frugalware gentoo linux-mint mandriva opensuse redhat slackware ubuntu flash rpmdrake skype; do

+   for nonfree in adobe-air AdobeAIR AdobeReader AdobeReader8 AdobeReader9 AdobeReader10 acroread amazon-mp3-store-source amazon-store as-icon as-powered autoplus archlinux checkgmail chromium chromium-browser chromium-browser2 debian defcon easylife evernote facebook fedora firefox firefox-3.0 firefox-3.5 firefox-4.0 firefox-original flash frugalware gentoo gmail gmailwatcher goa-account-facebook goa-account-google goa-account-twitter goa-account-yahoo google google-chrome google-chrome2 google-chrome-unstable google-earth googleearth googlemusicframe google-plus gtwitter last-fm lastfm-audioscrobbler linux-mint mandriva mendeley mendeleydesktop nixnote novell opensuse opera opera-browser opera-widget opera-widget-manager picasa picasa32x32 picasa-fontcfg redhat rpmdrake skype slackware susehelpcenter twitter Twitter-twitter.com ubuntu yahoo youtube; do

     find -name *$nonfree* -delete

    done

  
@@ -50,4 +51,4 @@ 

    find "${pkgdir}" -type f -exec chmod 644 {} +

  }

  

- # vim: ts=2 sw=2 et:

+ # vim: ts=2 sw=2 et: 

\ No newline at end of file

some proprietary services icoon like google facebook skype etc.. still lurking in the source.
update more icon cleaning from prior version.

thanks for looking into that

are you using these builds? - these changes do not break anything?

im cloned the abslibre repo, updating the source checksum with updpkgsum and tested build with makepkg -si and install it locally, no error so far

however im not very sure, im still learning with git. would you revise and check it once more ? thanks in advance

this 'Contributor' should be restored

a simple way to accomplish that:

  $ git checkout pull-requests
  # make the change to libre/faience-icon-theme/PKGBUILD
  $ git commit --amend libre/faience-icon-theme/PKGBUILD
  $ git push --force pagure pull-requests

would you revise and check it once more ?

yes - that is normal practice for software projects (the process of "code review") - i suggest the one revision above

by "broken", i meant: will any programs crash or look ugly if it tries to use a missing font?

are the removed glyphs normal fonts? ie: do you know the unicodes?

do you know of any programs which may try to display one of the missing glyphs to the user?

1 new commit added

  • Update libre/faience-icon-theme/PKGBUILD
2 months ago

this 'Contributor' should be restored

fixed, accidentaly repasted on top of that, sorry @Jorge

$ git commit --amend libre/faience-icon-theme/PKGBUILD
$ git push --force pagure pull-requests
```

im trying many method without success so
fatal: unable to access 'https://pagure.io/abslibre.git/': The requested URL returned error: 403

by "broken", i meant: will any programs crash or look ugly if it tries to use a missing font?

are the removed glyphs normal fonts? ie: do you know the unicodes?

do you know of any programs which may try to display one of the missing glyphs to the user?

no font or other system asset removed, im just mainly discard nonfree app icon in /usr/share/icons/iconsname/apps/ (the one who would show up in menu/app launcher if the app is installed) since we are FLOSS distro those icons would unlikely be used anyway thus become disk burden and also be a reference for nonfree things)

im used my revised icons and had many apps installed (inluding from aur)
nothing goes wrong so far
https://postimg.cc/gallery/N2mh9D0
if there any themeing project im also like to help :)

Pull-Request has been closed by dikasp

2 months ago

Pull-Request has been reopened by dikasp

2 months ago

thanks for all your help and concern, im sorry if im made many mistake in my learning process.

no font or other system asset removed, im just mainly discard nonfree app icon in /usr/share/icons/iconsname/apps/

ok those are probably safe to delete

fatal: unable to access 'https://pagure.io/abslibre.git/': The requested URL returned error: 403

that is the URL for this project - you are only able to push to your fork - i could give you permission in the future perhaps - to push to your fork:

  $ git remote add pagure https://pagure.io/forks/dikasp/abslibre.git

the command above only need to run once - then whenever you want to put changes on pagure:

  $ git push -f pagure pull-requests

fatal: unable to access 'https://pagure.io/abslibre.git/': The requested URL returned error: 403

that is the URL for this project - you are only able to push to your fork - i could give you permission in the future perhaps - to push to your fork:
$ git remote add pagure https://pagure.io/forks/dikasp/abslibre.git

i think im not ready to pushing directly to master, there is so much i dont know yet. thanks for the tutorial and your patience @billauger

2 new commits added

  • update
  • update
2 months ago

1 new commit added

  • remove wrong pcr submission
2 months ago