PR#4141: Few fixes for gcc10 - SSSD/sssd

Lukas Slebodnik • 4 years ago

2084213

Lukas Slebodnik • 4 years ago

400eea2

src/providers/proxy/proxy_id.c

file modified

+10 -3

		`@@ -212,9 +212,16 @@`
		`{`
		`int ret = EOK;`

		`- DEBUG(SSSDBG_TRACE_FUNC,`
		`- "User %s does not exist (or is invalid) on remote server,"`
		`- " deleting!\n", name);`
		`+ if (name != NULL) {`
		`+ DEBUG(SSSDBG_TRACE_FUNC,`
		`+ "User %s does not exist (or is invalid) on remote server,"`
		`+ " deleting!\n", name);`
		`+ } else {`
		`+ DEBUG(SSSDBG_TRACE_FUNC,`
		`+ "User with UID %"SPRIuid" does not exist (or is invalid) "`
		`+ "on remote server, deleting!\n", uid);`
		`+ }`
		`+`
		`ret = sysdb_delete_user(domain, name, uid);`
		`if (ret == ENOENT) {`
		`ret = EOK;`

src/tests/cmocka/test_nss_srv.c

file modified

		`@@ -403,6 +403,8 @@`
		`gr->gr_passwd = (char *) body+rp;`
		`rp += strlen(gr->gr_passwd) + 1;`

		`+ gr->gr_mem = NULL;`
		`+`
		`if (*nmem > 0) {`
		`gr->gr_mem = talloc_zero_array(nss_test_ctx, char , nmem);`
		`if (gr->gr_mem == NULL) return ENOMEM;`

thank you for the patch, it makes sense and works for me. ACK.

bye,
Sumit

Commit d7ddcc5 fixes this pull-request

Pull-Request has been merged by pbrezina

4 years ago

master
- d7ddcc5 - test_nss_srv: Suppress Conditional jump or move depends on uninitialised value
- 3bdce86 - PROXY: Fix warning-format-overflow directive argument is null