PR#4107: sss_client/idmap/common_ex.c: fix sss_nss_timedlock() to return errno - SSSD/sssd

SSSD / sssd

#4107 sss_client/idmap/common_ex.c: fix sss_nss_timedlock() to return errno

Closed 4 years ago by atikhonov. Opened 4 years ago by miztake.

SSSD/ miztake/sssd prototype into master

sss_client/idmap/common_ex.c: fix sss_nss_timedlock() to return errno

MIZUTA Takeshi • 4 years ago

0b1d79a

src/sss_client/idmap/common_ex.c

file modified

+2 -1

		`@@ -73,7 +73,7 @@`

		`ret = clock_gettime(CLOCK_REALTIME, &starttime);`
		`if (ret != 0) {`
		`- return ret;`
		`+ return errno;`
		`}`
		`endtime.tv_sec = starttime.tv_sec + SEC_FROM_MSEC(timeout_ms);`
		`endtime.tv_nsec = starttime.tv_nsec + NSEC_FROM_MSEC(timeout_ms);`
		`@@ -83,6 +83,7 @@`
		`if (ret == 0) {`
		`ret = clock_gettime(CLOCK_REALTIME, &endtime);`
		`if (ret != 0) {`
		`+ ret = errno;`
		`sss_nss_unlock();`
		`return ret;`
		`}`

miztake commented 4 years ago

sss_nss_timedloc() should return errno, but returns -1 if clock_gettime(2) fails.
Fix sss_nss_timedlock() to return errno if clock_gettime(2) fails.

sbose commented 4 years ago

Hi,

thank you for the patch. I wonder if you can send it to https://github.com/SSSD/sssd/ as well? This is our preferred place for pull-request since automatic tests are run there for every new pull-request.

bye,
Sumit