#4001 Update OpenRC init.d script
Closed 3 years ago by pbrezina. Opened 4 years ago by jockesssd.
SSSD/ jockesssd/sssd openrc  into  master

file modified
+25 -12
@@ -1,18 +1,31 @@ 

- #!/sbin/runscript

+ #!/sbin/openrc-run

+ # Copyright 1999-2019 Gentoo Authors
sbose commented 4 years ago

Is 1999 typical for Gentoo init.d scripts? SSSD is available since 2008.

+ # Distributed under the terms of the GNU General Public License v2
sbose commented 4 years ago

SSSD is distributed under GPL v3. I'm not sure about what are the implications of having v2 in a file. If you think v2 is important here and cannot be changed to v3 I have to check with people more familiar with licenses if we can include it.

+ 

+ 

+ command="@sbindir@/sssd"

+ command_args="-Df ${SSSD_OPTIONS}"

+ description="System Security Services Daemon"

+ pidfile="@pidpath@/sssd.pid"

+ #sssd may take time time to TERMinate so allow som extra time

+ retry="TERM/60"

+ extra_started_commands="rotate online offline"

  

  depend(){

-     need localmount netmount clock

-     use syslog xdm

+     need localmount clock

+     use syslog

+     before xdm

  }

  

- start(){

-     ebegin "Starting sssd"

-     start-stop-daemon --start --exec @sbindir@/sssd -- -Df ${SSSD_OPTIONS}

-     eend ${?}

+ do_sig() {

+ 	local sig=$1 ; shift

+ 	ebegin "$*"

+ 	start-stop-daemon --signal ${sig} --pidfile ${pidfile}

+ 	eend $?

  }

  

- stop(){

-     ebegin "Stopping sssd"

-     start-stop-daemon --stop --pidfile @localstatedir@/run/sssd.pid

-     eend ${?}

- }

+ rotate() { do_sig HUP  "Sends sssd a signal to re-open its log files." ; }

+ 

+ offline() { do_sig USR1  "Simulate offline" ; }

+ 

+ online() { do_sig USR2  "Simulate online" ; }

Modernize the script, add TERM delay,rotate,online and offline

rebased onto 62bef7d

4 years ago

rebased onto 203de57

4 years ago

Is 1999 typical for Gentoo init.d scripts? SSSD is available since 2008.

SSSD is distributed under GPL v3. I'm not sure about what are the implications of having v2 in a file. If you think v2 is important here and cannot be changed to v3 I have to check with people more familiar with licenses if we can include it.

Is 1999 typical for Gentoo init.d scripts? SSSD is available since 2008.

Forgot about this PR, yes this is standard in Gentoo.

SSSD is distributed under GPL v3. I'm not sure about what are the implications of having v2 in a file. If you think v2 is important here and cannot be changed to v3 I have to check with people more familiar with licenses if we can include it.

You an change it to GPL3 v3 if you like, I don't care if its GPLv2 or GPLv3

@jockesssd IMHO it make a sense to merge PR.
Especially, if it simplify downstream changes in Gentoo. Just change comment to gpl3 :-)

Thank you. I changed licence to v3 and pushed.

  • master
    • 494b838 - Update OpenRC init.d script

Pull-Request has been closed by pbrezina

3 years ago
Metadata