PR#3853: p11_child: Fix warnings may be used uninitialized - SSSD/sssd

SSSD / sssd

#3853 p11_child: Fix warnings may be used uninitialized

Closed 5 years ago by sbose. Opened 5 years ago by lslebodn.

SSSD/ lslebodn/sssd p11_child_uninit2 into master

p11_child: Fix warnings may be used uninitialized

Lukas Slebodnik • 5 years ago

9efe8cc

src/p11_child/p11_child_openssl.c

file modified

+2 -2

		`@@ -666,8 +666,8 @@`
		`{`
		`int ret;`
		`size_t c;`
		`- size_t s;`
		`- CK_FUNCTION_LIST **modules;`
		`+ size_t s = 0;`
		`+ CK_FUNCTION_LIST **modules = NULL;`
		`CK_FUNCTION_LIST *module = NULL;`
		`char *mod_name;`
		`char *mod_file_name;`

lslebodn commented 5 years ago

The variable modules can be uninitialized in done section in case of
failure p11_kit_uri_parse(uri_str, P11_KIT_URI_FOR_ANY, uri).

And compiler can expect the variable "s" to be uninitialized in case of
always matching condition for "Skip modules which do not match the PKCS#11 URI"

src/p11_child/p11_child_openssl.c: In function ‘do_card’:
src/p11_child/p11_child_openssl.c:1046:5: error: ‘modules’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
p11_kit_modules_finalize_and_release(modules);
^
src/p11_child/p11_child_openssl.c:830:20: error: ‘s’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
slot_id = slots[s];
~^~~
Merges: https://pagure.io/SSSD/sssd/pull-request/3853