#3714 SPEC: Move secrets responder to the package sssd-kcm
Merged 5 years ago by jhrozek. Opened 5 years ago by lslebodn.
SSSD/ lslebodn/sssd spec_secrets  into  master

file modified
+11 -11
@@ -960,8 +960,6 @@ 

  %{_unitdir}/sssd-ssh.service

  %{_unitdir}/sssd-sudo.socket

  %{_unitdir}/sssd-sudo.service

- %{_unitdir}/sssd-secrets.socket

- %{_unitdir}/sssd-secrets.service

  %else

  %{_initrddir}/%{name}

  %endif
@@ -971,9 +969,6 @@ 

  %{_libexecdir}/%{servicename}/sssd_nss

  %{_libexecdir}/%{servicename}/sssd_pam

  %{_libexecdir}/%{servicename}/sssd_autofs

- %if (0%{?with_secrets} == 1)

- %{_libexecdir}/%{servicename}/sssd_secrets

- %endif

  %{_libexecdir}/%{servicename}/sssd_ssh

  %{_libexecdir}/%{servicename}/sssd_sudo

  %{_libexecdir}/%{servicename}/p11_child
@@ -1006,9 +1001,6 @@ 

  %dir %{_localstatedir}/cache/krb5rcache

  %attr(700,sssd,sssd) %dir %{dbpath}

  %attr(755,sssd,sssd) %dir %{mcpath}

- %if (0%{?with_secrets} == 1)

- %attr(700,root,root) %dir %{secdbpath}

- %endif

  %attr(751,sssd,sssd) %dir %{deskprofilepath}

  %ghost %attr(0644,sssd,sssd) %verify(not md5 size mtime) %{mcpath}/passwd

  %ghost %attr(0644,sssd,sssd) %verify(not md5 size mtime) %{mcpath}/group
@@ -1043,9 +1035,6 @@ 

  %{_mandir}/man5/sssd-simple.5*

  %{_mandir}/man5/sssd-sudo.5*

  %{_mandir}/man5/sssd-session-recording.5*

- %if (0%{?with_secrets} == 1)

- %{_mandir}/man5/sssd-secrets.5*

- %endif

  %{_mandir}/man8/sssd.8*

  %{_mandir}/man8/sss_cache.8*

  %if (0%{?enable_systemtap} == 1)
@@ -1318,12 +1307,23 @@ 

  

  %if (0%{?with_kcm} == 1)

  %files kcm -f sssd_kcm.lang

+ %if (0%{?with_secrets} == 1)

+ %attr(700,root,root) %dir %{secdbpath}

+ %endif

  %{_libexecdir}/%{servicename}/sssd_kcm

+ %if (0%{?with_secrets} == 1)

+ %{_libexecdir}/%{servicename}/sssd_secrets

+ %endif

  %dir %{_datadir}/sssd-kcm

  %{_datadir}/sssd-kcm/kcm_default_ccache

  %{_unitdir}/sssd-kcm.socket

  %{_unitdir}/sssd-kcm.service

+ %{_unitdir}/sssd-secrets.socket

+ %{_unitdir}/sssd-secrets.service

  %{_mandir}/man8/sssd-kcm.8*

+ %if (0%{?with_secrets} == 1)

+ %{_mandir}/man5/sssd-secrets.5*

+ %endif

  %endif

  

  %pre common

The sssd secrets responder is used mainly by sssd-kcm and it is not
used by any service which is in the sub-package sssd-common.
Therefore it make more sense to have secrets responder in the pacakge
sssd-kcm and reduce dependencies of sssd-common package
(http-parser, jansson)
Note: libcurl is installed anyway on fedora due to other dependencies

PR #3713 was prematurely closed before reaching consensus between @lslebodn and @jhrozek. It is not possible to reopen PR ATM in pagure therefore new PR was created.

@jhrozek,

It seems that it will take some time till #3685 will be implemented (it's planned for 2.0). But it would be good to move this forward. It will be very useful for distributions which does not have sssd-kcm in default installation(fc28, el6, el7)[1] and thus sssd-secrets is unused.

[1] https://pagure.io/fedora-comps/blob/master/f/comps-f28.xml.in

rebased onto 5170efe616847a619263e5039f6bb8f9af68e7e9

5 years ago

I rebased PR on top of current master.

@jhrozek, would it be possible to merge this PR after 3 months?
I cannot see any progress in #3685 and it will remove unnecessary dependencies in fedora28 and rhel7

rebased onto ce1fa46

5 years ago

My progress had been slow due to RHEL-7.6 bugs (you know how it is..) so I think you are right and we should merge this PR.

ACK

Commit 7b25811 fixes this pull-request

Pull-Request has been merged by jhrozek

5 years ago
Metadata