PR#3645: Avoid double semicolon warnings on older compilers - SSSD/sssd

SSSD / sssd

#3645 Avoid double semicolon warnings on older compilers

Merged 6 years ago by lslebodn. Opened 6 years ago by asn.

SSSD/ asn/sssd master-fallthrough into master

Avoid double semicolon warnings on older compilers

Andreas Schneider • 6 years ago

1043b0b

configure.ac

file modified

+1 -1

		`@@ -459,7 +459,7 @@`
		`sss_cv_attribute_fallthrough_val="__attribute__ ((fallthrough))"`
		`],[`
		`sss_cv_attribute_fallthrough=no`
		`- sss_cv_attribute_fallthrough_val=`
		`+ sss_cv_attribute_fallthrough_val="((void)0)"`
lslebodn commented 6 years ago maybe we could expand that to comment which is recognized by linters, static analyzers. e.g. "/ fallthrough /" I didn't test that because I already have gcc8 on my machine :-)
		`])`
		`])`
		`CFLAGS=$SAFE_CFLAGS`

asn commented 6 years ago

Compilers that don't support fallthrough will end up with an empty
SSS_ATTRIBUTE_FALLTHROUGH define and just see a semicolon. The probably
will warn that there are double semicolons in the code.

Signed-off-by: Andreas Schneider asn@redhat.com

lslebodn commented on line 6 of configure.ac 6 years ago

maybe we could expand that to comment which is recognized by linters, static analyzers. e.g. "/ fallthrough /"

I didn't test that because I already have gcc8 on my machine :-)

asn commented 6 years ago

that would just add a comment to the #define

#define SSS_ATTRIBUTE_FALLTHROUGH ((void)0) /* fall through */

Edited 6 years ago by asn

lslebodn commented 6 years ago

/facepalm

ACK

lslebodn commented 6 years ago