#864 Refactor sdap_async_accounts.c
Closed: Fixed None Opened 9 years ago by sgallagh.

The file sdap_async_accounts.c has grown to the point where it is unmanageable. We need to refactor it into smaller files, each providing a particular piece of the puzzle.

I propose that it should be broken into:

sdap_async_accounts_users.c::
Common functions for processing user lookups

sdap_async_accounts_initgroups.c::
Common functions for processing initgroups

sdap_async_accounts_initgroups_2307.c::
The real workhorse for initgroups on RFC2307 servers

sdap_async_accounts_initgroups_2307bis.c::
The real workhorse for initgroups on RFC2307bis servers

sdap_async_accounts_groups.c::
Common functions for processing groups

sdap_async_accounts_groups_2307.c::
RFC2307-specific group processing

sdap_async_accounts_groups_2307bis.c::
RFC2307bis-specific group processing


Fields changed

version: 1.5.7 => master

I'll take the ticket, I'm very excited about this effort.

Notes:
- some *_common file(s) should be added because some routines are used on more places
- review of 2307 / 2307bis routines should be done. I noticed couple of them which looked pretty similar and perhaps could be merged.

owner: somebody => jzeleny

Fields changed

milestone: NEEDS_TRIAGE => SSSD 1.6.0
priority: major => trivial

Fields changed

milestone: SSSD 1.6.0 => SSSD 1.7.0
priority: trivial => major

Do it first in 1.7 cycle.

priority: major => blocker

Fields changed

status: new => assigned

Fields changed

patch: 0 => 1

Fields changed

milestone: SSSD 1.8.0 => SSSD 1.7.0

Fixed in master:

f26c954

9212323

f41bb1d

9091fde

resolution: => fixed
rhbz: =>
status: assigned => closed

Fields changed

rhbz: => 0

Metadata Update from @sgallagh:
- Issue assigned to jzeleny
- Issue set to the milestone: SSSD 1.7.0

3 years ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/1906

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Login to comment on this ticket.

Metadata