#722 Incorrect return value on failure in check_and_export_options
Closed: Fixed None Opened 13 years ago by sgallagh.

A negative return value of "check_and_export_lifetime" is assigned to signed variable "ret".
Function "check_and_export_lifetime(opts, 10, &"SSSD_KRB5_LIFETIME")" returns a negative number. [show details]
  136    ret = check_and_export_lifetime(opts, KRB5_LIFETIME,
  137                                    SSSD_KRB5_LIFETIME);
At conditional (1): "ret != 0" taking the true branch.
  138    if (ret != EOK) {
At conditional (2): "1 <= debug_level" taking the true branch.
At conditional (3): "debug_timestamps" taking the true branch.
"ret" is passed to a parameter that cannot be negative.
  139        DEBUG(1, ("Failed to check value of krb5_lifetime. [%d][%s]\n",
  140                  ret, strerror(ret)));
  141        return ret;
  142    }

in check_and_export_lifetime(), we return the result of setenv() if it's nonzero. However, we should be returning the errno that it sets.


Fields changed

milestone: NEEDS_TRIAGE => SSSD 1.5.0

Fixed by 223769b

coverity: => 10013
resolution: => fixed
status: new => closed

Fields changed

rhbz: => 0

Metadata Update from @sgallagh:
- Issue assigned to sbose
- Issue set to the milestone: SSSD 1.5.0

7 years ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/1764

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Login to comment on this ticket.

Metadata