#720 Missing break statement in sss_hash_create
Closed: Fixed None Opened 10 years ago by sgallagh.

  493    switch (hret) {
  494    case HASH_SUCCESS:
  495        /* Steal the table pointer onto the mem_ctx,
  496         * then make the internal_ctx a child of
  497         * table.
  498         *
  499         * This way, we can clean up the values when
  500         * we talloc_free() the table
  501         */
  502        *tbl = talloc_steal(mem_ctx, table);
  503        talloc_steal(table, internal_ctx);
  504        return EOK;
This case (value -1997) is not terminated by a 'break' statement.
  506    case HASH_ERROR_NO_MEMORY:
  507        ret = ENOMEM;
The above case falls through to this one.
  508    default:
  509        ret = EIO;
  510    }

We want to make sure to log the correct error message if something goes wrong.

Fields changed

milestone: NEEDS_TRIAGE => SSSD 1.5.0

Fixed by cde740b

coverity: => 10011
resolution: => fixed
status: new => closed

Fields changed

rhbz: => 0

Metadata Update from @sgallagh:
- Issue assigned to sgallagh
- Issue set to the milestone: SSSD 1.5.0

4 years ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/1762

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Login to comment on this ticket.