#65 Refactor delete_property function to accept same set of parameters as extract_item function
Closed: Fixed None Opened 14 years ago by dpal.

Recently an extraction function has been added to collection interface. It provides much more flexibility about which item needs to be extracted from the collection (first, last, after given property, before given property, etc). The delete function can be wrapped around extraction function now and take advantage of the extraction function flexibility.


Fields changed

component: SSSD => libcollection
milestone: Iteration 6 => Deferred
status: new => assigned
version: => 0.4.1

This functionality is not required by any consumer of the API at the moment thus can be postponed.

doc: => 0
docupdated: => 0
proposed: => 2.0
tests: => 0
testsupdated: => 0

Hm actually I reread the bug more closely and realized that this part is already implemented in earlier patches.

/* Remove item (property) from collection.
 * It is similar to delete_property function but allows more specific
 * information about what item (property) to remove.
 * The header will not be considered for deletion.
 */
int col_remove_item(struct collection_item *ci,        /* Top collection */
                    const char *subcollection,         /* Sub collection */
                    int disposition,                   /* Which to remove */
                    const char *refprop,               /* Property to relate to */
                    int idx,                           /* Index of the property to remove. See notes. */
                    int type);                         /* Type filter */

Thus closing the bug.

proposed: 2.0 =>
resolution: => fixed
status: assigned => closed

Fields changed

fixedin: => 1.0.0

Fields changed

coverity: =>
milestone: SSSD Deferred => SSSD 1.0

Fields changed

rhbz: => 0

Metadata Update from @dpal:
- Issue assigned to dpal
- Issue set to the milestone: SSSD 1.0

7 years ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/1107

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Login to comment on this ticket.

Metadata