#586 assorted minor bugs found by clang in the providers code
Closed: Fixed None Opened 13 years ago by jhrozek.

These minor bugs were found by the clang static analyser:

- the `ev` variable is not used in `proxy_get_account_info`:
    - http://jhrozek.fedorapeople.org/sssd-clang-llvm/report-OB44fx.html#EndPath

- the `ret` variable is not used in `child_cleanup`:
    - http://jhrozek.fedorapeople.org/sssd-clang-llvm/report-knzA6j.html#EndPath
    - http://jhrozek.fedorapeople.org/sssd-clang-llvm/report-o25Zx7.html#EndPath

- the `attr` variable is not used in `enum_groups_send`:
    - http://jhrozek.fedorapeople.org/sssd-clang-llvm/report-JDhOmf.html#EndPath

- the first assignment to `ret` is not needed in `dp_get_options`:
    - http://jhrozek.fedorapeople.org/sssd-clang-llvm/report-42UwAT.html#EndPath

- extra assignment to `ret` in `create_ccache_file`:
    - http://jhrozek.fedorapeople.org/sssd-clang-llvm/report-NjN7RO.html#EndPath

- the value of `ret` does not need to be saved in the assignment:
    - http://jhrozek.fedorapeople.org/sssd-clang-llvm/report-YAYjYm.html#EndPath

- the value of `ret` is never checked in `sdap_access_send`:
    - http://jhrozek.fedorapeople.org/sssd-clang-llvm/report-Splm9p.html#EndPath

Fields changed

milestone: NEEDS_TRIAGE => SSSD 1.4.0

Fields changed

owner: somebody => jzeleny

Code related to the following report has changed. The code has been moved to function sss_krb5_verify_keytab_ex() inside file util/sss_krb5.c and the issue has been fixed there.

http://jhrozek.fedorapeople.org/sssd-clang-llvm/report-YAYjYm.html#EndPath

Other reports are still valid and will be fixed.

Fixed by 87f2bb6

fixedin: => 1.4.0
resolution: => fixed
status: new => closed

Fields changed

rhbz: => 0

Metadata Update from @jhrozek:
- Issue assigned to jzeleny
- Issue set to the milestone: SSSD 1.4.0

7 years ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/1628

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Login to comment on this ticket.

Metadata