#524 Unchecked tevent_add_timer() return in ldap cache cleanup code
Closed: Fixed None Opened 13 years ago by sgallagh.

From Coverity:

Pointer "timeout" returned by "_tevent_add_timer(ctx->be->ev, req, tv, ldap_id_enumerate_timeout, req, &"ldap_id_enumerate_timeout", &"providers/ldap/ldap_id_enum.c:82")" is never used.
   82    timeout = tevent_add_timer(ctx->be->ev, req, tv,
   83                               ldap_id_enumerate_timeout, req);

The reason for this variable is for the NULL check that should be performed to verify that the timer was created. It's missing from both ldap_id_enumerate_timer() and ldap_id_cleanup_timer()


Fields changed

milestone: NEEDS_TRIAGE => SSSD 1.2.1
owner: somebody => sgallagh
status: new => assigned

Fields changed

keywords: => coverity

Fixed by 3fcf293

fixedin: => 1.2.1
resolution: => fixed
status: assigned => closed

Fields changed

rhbz: => 0

Metadata Update from @sgallagh:
- Issue assigned to sgallagh
- Issue set to the milestone: SSSD 1.2.1

7 years ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/1566

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Login to comment on this ticket.

Metadata