#523 Incorrect memory allocation check could hide an allocation failure error
Closed: Fixed None Opened 13 years ago by sgallagh.

From Coverity:

Pointer "tev" returned by "_tevent_add_timer(ev, rw_ctx, tv, rewatch_config_file, rw_ctx, &"rewatch_config_file", &"monitor/monitor.c:1437")" is never used.
 1437        tev = tevent_add_timer(ev, rw_ctx, tv, rewatch_config_file, rw_ctx);
 1438        if (te == NULL) {
 1439            DEBUG(0, ("Could not restore inotify watch. Quitting!\n"));
 1440            close(file_ctx->mt_ctx->inotify_fd);
 1441            kill(getpid(), SIGTERM);
 1442        }

The NULL check here is incorrect. It should be looking at tev.

This appears in process_config_file(), rewatch_config_file() and be_run_cb_step().


Also appears in sss_dp_invoke_callback()

Fields changed

milestone: NEEDS_TRIAGE => SSSD 1.2.1
owner: somebody => sgallagh
status: new => assigned

Fields changed

keywords: => coverity

Fixed by a0c2934

fixedin: => 1.2.1
resolution: => fixed
status: assigned => closed

Fields changed

rhbz: => 0

Metadata Update from @sgallagh:
- Issue assigned to sgallagh
- Issue set to the milestone: SSSD 1.2.1

7 years ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/1565

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Login to comment on this ticket.

Metadata