#512 Switch statement missing a break causes unintended implicit setting of options in sss_useradd
Closed: Fixed None Opened 13 years ago by sgallagh.

From Coverity:

  147    while ((ret = poptGetNextOpt(pc)) > 0) {
  148        switch (ret) {
This case (value 71) is not terminated by a 'break' statement.
  149            case 'G':
  150                groups = poptGetOptArg(pc);
  151                if (!groups) goto fini;
  152
The above case falls through to this one.
  153            case 'm':
  154                pc_create_home = DO_CREATE_HOME;
  155                break;

In this case, passing -G results in implicitly setting -m.


Fields changed

milestone: NEEDS_TRIAGE => SSSD 1.2.1

Fixed by 1bdeea6

fixedin: => 1.2.1
keywords: => coverity
resolution: => fixed
status: new => closed

Fields changed

rhbz: => 0

Metadata Update from @sgallagh:
- Issue assigned to jhrozek
- Issue set to the milestone: SSSD 1.2.1

7 years ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/1554

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Login to comment on this ticket.

Metadata