#4169 "off-by-one error" in watchdog implementation
Closed: Fixed 4 years ago by pbrezina. Opened 4 years ago by atikhonov.

'man sssd.conf': timeout: "Note that after three missed heartbeats the process will terminate itself."

But implementation is:

#define WATCHDOG_MAX_TICKS 3
...
    if (__sync_add_and_fetch(&watchdog_ctx.ticks, 1) > WATCHDOG_MAX_TICKS) {
        ...
        _exit(1);

-- since after reset ticks start from 0 effectively this is 4 heartbeats.


Metadata Update from @atikhonov:
- Issue assigned to atikhonov

4 years ago

Metadata Update from @atikhonov:
- Issue tagged with: PR

4 years ago

Metadata Update from @thalman:
- Issue tagged with: Next milestone

4 years ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/5124

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Login to comment on this ticket.

Metadata