#4168 SSSD-1-16: sbus_auto_reconnect(): "off-by-one error" in `reconnection_retries` interpretation
Closed: Fixed 8 months ago by atikhonov. Opened 8 months ago by atikhonov.

(applies only to sssd-1-16, master branch is not affected)

static int sbus_auto_reconnect(struct sbus_connection *conn)
{
...
    conn->retries++;
    if (conn->retries >= conn->max_retries) {
        /* Return EIO (to tell the calling process it
         * needs to create a new connection from scratch
         */
        return EIO;
    }

-- if max_retries (reconnection_retries option) == 1 then very first call to sbus_auto_reconnect() will fail.


Metadata Update from @atikhonov:
- Custom field rhbz adjusted to https://bugzilla.redhat.com/show_bug.cgi?id=1801401

8 months ago

Metadata Update from @atikhonov:
- Issue assigned to atikhonov

8 months ago

Metadata Update from @atikhonov:
- Issue tagged with: PR

8 months ago

Metadata Update from @thalman:
- Issue tagged with: Next milestone

8 months ago
sssd-1-16
    a1bdab3 - SBUS: fixed off-by-one error" in sbus_auto_reconnect()

Metadata Update from @atikhonov:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

8 months ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/5123

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Login to comment on this ticket.

Metadata