#3914 `test_pam_responder.py` needs improvement
Closed: Fixed a year ago by pbrezina. Opened 2 years ago by atikhonov.

For the OpenSSL build the NSS database is not needed at all and create_nssdb_fixture and create_nssdb_no_cert_fixture in test_pam_responder.py do not have to be called.

And since CI build for Debian is using OpenSSL this improvement would allow to drop libnss3-dev from Debian dependency list in contrib/ci/deps.sh

See https://github.com/SSSD/sssd/pull/720 for details.


Metadata Update from @jhrozek:
- Issue set to the milestone: SSSD Patches welcome

2 years ago

@atikhonov do you have any ideas on how to invoke test_pam_responder.py? I do not see that this test is being executed as part of other tests when you compile SSSD.

@atikhonov do you have any ideas on how to invoke test_pam_responder.py? I do not see that this test is being executed as part of other tests when you compile SSSD.

Hi,

this is run as part of the integration tests, see https://docs.pagure.org/SSSD.sssd/developers/tests.html#running-integration-tests for details.

make intgcheck-prepare
INTGCHECK_PYTEST_ARGS="-k test_pam_responder.py" make intgcheck-run

should run the tests.

HTH

bye,
Sumit

How to differentiate between OpenSSL and NSS builds inside a Python program? I can try to import nss.nss and in the case of failure do not call create_nssdb_fixture & create_nssdb_no_cert_fixture functions. What do you think?

How to differentiate between OpenSSL and NSS builds inside a Python program? I can try to import nss.nss and in the case of failure do not call create_nssdb_fixture & create_nssdb_no_cert_fixture functions. What do you think?

Even if you doing an OpenSSL build, nss.nss might still be installed in the system, so I think you cannot rely on this.

Depending on where you need this information I think environment variables set in Makefile.am might help. Search for 'HAVE_NSS' in tests/intg/Makefile.am for examples.

HTH

bye,
Sumit

Metadata Update from @atikhonov:
- Issue tagged with: PR

a year ago
  • master
    • 16124d4 - Updated test_pam_responder.py

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/4899

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Login to comment on this ticket.

Metadata