#3791 The cached password does not store the salt prefix
Closed: Fixed 5 years ago Opened 5 years ago by jhrozek.

Since commit 2951a9a where we switched from stpncpy to memcpy the salt prefix "$6$" is not stored at all. This breaks offline authentication if someone upgraded from the version that stored the prefix to one that doesn't store it.


Metadata Update from @jhrozek:
- Custom field rhbz adjusted to https://bugzilla.redhat.com/show_bug.cgi?id=1602781

5 years ago

Metadata Update from @jhrozek:
- Issue tagged with: bug, regression

5 years ago

Metadata Update from @jhrozek:
- Issue assigned to mzidek
- Issue priority set to: blocker

5 years ago

Metadata Update from @jhrozek:
- Issue tagged with: PR

5 years ago

Metadata Update from @jhrozek:
- Issue close_status updated to: Fixed
- Issue set to the milestone: SSSD 1.16.3
- Issue status updated to: Closed (was: Open)

5 years ago

I would say there is a different solution which does not introduce a compile time warning.

@jhrozek, please check changes in https://pagure.io/SSSD/sssd/pull-request/3792. It even contains a unit test

Metadata Update from @lslebodn:
- Issue status updated to: Open (was: Closed)

5 years ago

Metadata Update from @jhrozek:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

5 years ago

master:
f62d2af
8e1576b

last two patches should be backported also to 1.4 and 1.13 branch

Thanks, I didn't realise we broke 1.13 and 1.14 as well.

sssd-1-14:
* 46682a1
* 89a05bd
sssd-1-13:
* c7636e4

(The test doesn't apply to sssd-1-13 and I currently have no time for a backport. Feel free to submit another PR if you feel strongly the test should go to sssd-1-13)

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/4789

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Log in to comment on this ticket.

Metadata