#3569 The cache_req code doesn't check the min_id/max_id boundaries for requests by ID
Closed: Fixed 7 years ago Opened 7 years ago by jhrozek.

Even though a domain sets min_id/max_id limits, the cache_req code currently forwards all requests into the back end. The objects are filtered when saved (see e.g. sysdb_add_user), but at the very least, this is causing unnecessary searches.

I think it would be enough to extend all the .lookup_fn function in each plugin that searches by ID (so, e.g cache_req_group_by_id_lookup() in src/responder/common/cache_req/plugins/cache_req_group_by_id.c, same for user-by-UID and object-by-ID) for a check that returns EOK but a NULL result if the entry is out of the range.


Metadata Update from @jhrozek:
- Custom field rhbz adjusted to https://bugzilla.redhat.com/show_bug.cgi?id=1512027

7 years ago

Metadata Update from @jhrozek:
- Issue assigned to amitkumar25nov
- Issue priority set to: critical
- Issue set to the milestone: SSSD 1.16.1
- Issue tagged with: PR, bug

7 years ago

Metadata Update from @jhrozek:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

7 years ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/4593

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Log in to comment on this ticket.

Metadata