#3563 Some sysdb tests fail because they expect a certain order of entries returned from ldb
Closed: Fixed 6 years ago Opened 6 years ago by jhrozek.

With recent ldb versions, the order of entries returned from the database is different than it used to be, which causes some tests to fail.

We need to fix the tests to avoid expecting a fixed order.

@lslebodn already fixed Fedora, so his patch can be used at least as a guidance as per where to look.


Metadata Update from @jhrozek:
- Issue set to the milestone: SSSD 1.16.1

6 years ago

CC @mzidek

I wonder if you have time to take a look at this ticket? I suggest talking to @lslebodn first because I think Lukas had some ideas. But I think writing a generic utility function that would accept a an expected and results list, run diff_string_lists on both and make sure that there all strings are in both arrays would be enough.

On (06/11/17 08:50), Jakub Hrozek wrote:

CC @mzidek

I wonder if you have time to take a look at this ticket? I suggest talking to @lslebodn first because I think Lukas had some ideas. But I think writing a generic utility function that would accept a an expected and results list, run diff_string_lists on both and make sure that there all strings are in both arrays would be enough.

There are more ways how to solve it:

  • diff_string_lists
  • sort output before comparing values with expected results

And probably few more. It is just question how generic solution
it can be. Because diff_string_lists expect list of strings and
maybe it would be more convenient to have functions which would
accept ldb_msg or ldb_results + name of attribute.

LS

Metadata Update from @mzidek:
- Issue assigned to mzidek

6 years ago

Metadata Update from @lslebodn:
- Issue close_status updated to: Fixed

6 years ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/4587

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Login to comment on this ticket.

Metadata