#3337 Options allowed in subdomain_inherit should be allowed in subdomain section of sssd.conf

Created 9 months ago by mzidek
Modified 2 hours ago

Allow options that can be inherited by subdomain_inherit also in in subdomain section of sssd.conf so for more compact and easier subdomain configuration.

9 months ago

Metadata Update from @jhrozek:
- Issue set to the milestone: SSSD 1.15.3

9 months ago

Metadata Update from @jhrozek:
- Issue assigned to mzidek

use_fully_qualified_names converted in a63d74f

9 months ago

Metadata Update from @jhrozek:
- Issue priority set to: critical

7 months ago

Metadata Update from @jhrozek:
- Issue set to the milestone: SSSD 1.15.4 (was: SSSD 1.15.3)

4 months ago

Metadata Update from @jhrozek:
- Issue tagged with: cleanup-one-sixteen

4 months ago

Metadata Update from @jhrozek:
- Issue untagged with: cleanup-one-sixteen
- Issue tagged with: PR

3 months ago

Metadata Update from @lslebodn:
- Issue priority set to: blocker (was: critical)

This one doesn't seem to be a blocker anymore (although I've asked in the PR but got no answer in a few days).

I'm removing the "blocker" tag for now.

2 months ago

Metadata Update from @fidencio:
- Issue priority set to: critical (was: blocker)

Hmm.. sorry for the PR silence. All the messages from that thread ended up labeled us spam. I am looking through a bunch of such messages right now.

But I do agree that this should not be a blocker.

2 months ago

Metadata Update from @jhrozek:
- Issue set to the milestone: SSSD 1.16.1 (was: SSSD 1.15.4)

Since this is not a user-facing issue, I even think we should postpone this to 2.0

4 hours ago

Metadata Update from @jhrozek:
- Issue priority set to: minor (was: critical)
- Issue tagged with: postpone-to-2-0

Yes, this can be pushed to 2.0.

I mentioned it somewhere already, but if we want to add unit test for the changes made in the PR (requested change), we should fix this first: https://pagure.io/SSSD/sssd/issue/3338

Because the only way I can think of doing a unit test for that change would be to set the ignore_group_members option in subdomain section of sssd.conf and and then in check if the flag to ignore group members is set in the subdomain context. But currently we do not use the codepath that reads the config file in the unit tests #3338). If we change that adding a unit test would be cca two line change in existing test.

But I personally do not think unit tests for this type of changes are helpful at all. Because even if we check that ignore_group_members from config file is also in the subdomain context's flag, we do not know if the feature really works (because there is more to ignore_group_members then just setting a flag in subdomain context). This would be almost like checking if confdb actually works, which is covered already and would add no value IMO. If we really want to have tests for this in the upstream then we need to have infrastructure for testing subdomains and create an integration tests. If having upstream a test for this is a blocker for the PR then I would drop the PR/postpone it until we have way to create integration test in upstream.

Login to comment on this ticket.

cancel