#3334 sssctl config-check does not check any special characters in domain name of domain section

Created 8 months ago by lslebodn
Modified 2 months ago

Ticket was cloned from Red Hat Bugzilla (product Red Hat Enterprise Linux 7): Bug 1432325

Description of problem:sssctl config-check does not check any special character
in domain section of sssd after forward slash.


Version-Release number of selected component (if applicable):
sssd-1.15.1-1.el7.x86_64


How reproducible:
Always.


Steps to Reproduce:
1. yum install sssd sssd-tools.
2. Create sssd.conf with special character in domain name of domain section.
3. Run sssctl config-check.

Actual results:
sssctl config-check does not check the special character in domain name.


Expected results:
sssctl config-check should check the special character in domain name.


Additional info:
# cat /etc/sssd/sssd.conf

[sssd]
config_file_version = 2
domains = LDAP
services = nss, pam
debug_level = 9

[domain/LDA@P]
8 months ago

Metadata Update from @lslebodn:
- Custom field rhbz adjusted to https://bugzilla.redhat.com/show_bug.cgi?id=1432325

8 months ago

Metadata Update from @lslebodn:
- Custom field rhbz adjusted to https://bugzilla.redhat.com/show_bug.cgi?id=1432325

8 months ago

Metadata Update from @mzidek:
- Custom field rhbz reset
- Issue set to the milestone: None

8 months ago

Metadata Update from @jhrozek:
- Issue assigned to mzidek

8 months ago

Metadata Update from @jhrozek:
- Issue set to the milestone: SSSD 1.15.4

I would like to capture the discussion in the downstream bugzilla:
1. the regex must be changed to reflect the documentation
2. we thought about implementing a "strict" validator option. It probably wouldn't be used in sssd y default, because options might differ between releases and many users share the same config file across releases. But it would be possible to enable the option in CI.

Nonetheless, I don't think this is a critical ticket and I think the "easytag" could be added so that some external contributor can pick this up. What do you think @mzidek

3 months ago

Metadata Update from @jhrozek:
- Issue tagged with: easyfix

3 months ago

Metadata Update from @jhrozek:
- Issue tagged with: cleanup-patches-welcome

3 months ago

Metadata Update from @jhrozek:
- Issue untagged with: cleanup-patches-welcome
- Issue set to the milestone: SSSD Patches welcome (was: SSSD 1.15.4)

[root @fedora26]# sssd --version
1.15.4
[root @fedora26]# cat /etc/sssd/sssd.conf
[sssd]
config_file_version = 2
domains = LDAP
services = nss, pam
debug_level = 9

[domain/LDA @P]

[root @fedora26]# sssctl config-check
Issues identified by validators: 1
[rule/allowed_sections]: Section [domain/LDA @P] is not allowed. Check for typos.

Messages generated during configuration merging: 0

Used configuration snippet files: 0
[root @fedora26]# vim /etc/sssd/sssd.conf
[root @fedora26]# cat /etc/sssd/sssd.conf
[sssd]
config_file_version = 2
domains = LDAP
services = nss, pam
debug_level = 9

[domain/LDAP]
[root @fedora26]# sssctl config-check
Issues identified by validators: 0

Messages generated during configuration merging: 0

Used configuration snippet files: 0
[root @fedora26]#

Am I missing something? Looks Issue is not reproducible?

On Wednesday, September 13, 2017, Amit Kumar pagure@pagure.io wrote:

amitkumar25nov added a new comment to an issue you are following:
``
[root @fedora26]# sssd --version
1.15.4
[root @fedora26]# cat /etc/sssd/sssd.conf
[sssd]
config_file_version = 2
domains = LDAP
services = nss, pam
debug_level = 9

[domain/LDA @P]

[root @fedora26]# sssctl config-check
Issues identified by validators: 1
[rule/allowed_sections]: Section [domain/LDA @P] is not allowed. Check for
typos.

Messages generated during configuration merging: 0

Used configuration snippet files: 0
[root @fedora26]# vim /etc/sssd/sssd.conf
[root @fedora26]# cat /etc/sssd/sssd.conf
[sssd]
config_file_version = 2
domains = LDAP
services = nss, pam
debug_level = 9

[domain/LDAP]
[root @fedora26]# sssctl config-check
Issues identified by validators: 0

Messages generated during configuration merging: 0

Used configuration snippet files: 0
[root @fedora26]#

Am I missing something? Looks Issue is not reproducible?

In case the issue is not reproducible would be nice to know which commit
fixed it.

``

To reply, visit the link below or just reply to this email
https://pagure.io/SSSD/sssd/issue/3334

Login to comment on this ticket.

cancel