#3275 Unchecked return value of sss_cmd_empty_packet(pctx->creq->out);
Closed: Fixed None Opened 2 years ago by jhrozek.

In autofssrv_cmd.c:

313    pctx = talloc_get_type(cmdctx->cctx->protocol_ctx, struct cli_protocol);
314
315    /* Either we succeeded or no domains were eligible */
316    ret = sss_packet_new(pctx->creq, 0,
317                         sss_packet_get_cmd(pctx->creq->in),
318                         &pctx->creq->out);
   4. Condition ret == 0, taking true branch
319    if (ret == EOK) {
   5. Condition reqret == 2, taking true branch
320        if (reqret == ENOENT) {
   6. Condition debug_level & __debug_macro_level, taking true branch
321            DEBUG(SSSDBG_TRACE_FUNC, "setautomntent did not find requested map\n");
322            /* Notify the caller that this entry wasn't found */
   CID 14653 (#1 of 1): Unchecked return value (CHECKED_RETURN)7. check_return: Calling sss_cmd_empty_packet without checking return value (as is done elsewhere 4 out of 5 times).
323            sss_cmd_empty_packet(pctx->creq->out);

Fields changed

milestone: NEEDS_TRIAGE => SSSD 1.15 Alpha

Fields changed

owner: somebody => fidencio
patch: 0 => 1
status: new => assigned

master:

resolution: => fixed
status: assigned => closed
version: 1.14.2 => master

Fields changed

rhbz: => 0

Metadata Update from @jhrozek:
- Issue assigned to fidencio
- Issue set to the milestone: SSSD 1.15.0

2 years ago

Login to comment on this ticket.

Metadata