Fields changed

milestone: NEEDS_TRIAGE => SSSD Deferred

Fields changed

rhbz: => 0

https://github.com/SSSD/sssd/pull/902

Commit f24e5ab fixes this issue

• master
  • f24e5ab - Added ERROR and PRINT macros to the tools

I am reopening this because there still are printf and fprintf used in SSSD where PRINT and ERROR could be used.

Sorry I did not check the issue associated with the PR and though it was only about the sss_tools.c

So this needs one or few more patches still.

Ahg... those are not strings we translate. Closing again. Sorry for the spam :D

What about sssctl_domains.c:

puts(_("None so far.\n"));

?

There is also:

sssctl/sssctl_cert.c:            puts(name);
sssctl/sssctl_cert.c:        puts(" - no mapped users found -");
sssctl/sssctl_domains.c:        puts(name);

but those are not wrapped in _() so not so sure...

This can be changed to PRINT

puts(_("None so far.\n"));

This cannot be changed to PRINT:

sssctl/sssctl_cert.c:            puts(name);
sssctl/sssctl_domains.c:        puts(name);

This can be changed to PRINT if we want to translate the string (makes sense IMO):

sssctl/sssctl_cert.c:        puts(" - no mapped users found -");

@mzidek I can make those changes if you want.

@mzidek I can make those changes if you want.

Ok, if you send patches, we will review them. Thanks.

@mzidek done. PR https://github.com/SSSD/sssd/pull/910

Commit 258e9a5 fixes this issue

• master
  • 258e9a5 - Added PRINT macro in the sssctl tool

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/4111

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.