#30 Clean up warnings in NSS Responder
Closed: Fixed None Opened 11 years ago by sgallagh.

These were found when compiling on Fedora 11 (which is using GCC 4.4.0)

Compiling responder/nss/nsssrv_cmd.c
responder/nss/nsssrv_cmd.c: In function ‘nss_cmd_getinit_callback’:
responder/nss/nsssrv_cmd.c:2827: warning: ‘ret’ may be used uninitialized in this function
responder/nss/nsssrv_cmd.c: In function ‘nss_cmd_getpwnam_callback’:
responder/nss/nsssrv_cmd.c:288: warning: ‘ret’ may be used uninitialized in this function
responder/nss/nsssrv_cmd.c: In function ‘nss_cmd_setgrent_callback’:
responder/nss/nsssrv_cmd.c:2306: warning: ‘ret’ may be used uninitialized in this function
responder/nss/nsssrv_cmd.c: In function ‘nss_cmd_setpwent_callback’:
responder/nss/nsssrv_cmd.c:954: warning: ‘ret’ may be used uninitialized in this function
responder/nss/nsssrv_cmd.c: In function ‘nss_cmd_getpwuid_callback’:
responder/nss/nsssrv_cmd.c:657: warning: ‘ret’ may be used uninitialized in this function

Fields changed

description: These were found when compiling on Fedora 11 (which is using GCC 4.4.0)

Compiling responder/nss/nsssrv_cmd.c
responder/nss/nsssrv_cmd.c: In function ‘nss_cmd_getinit_callback’:
responder/nss/nsssrv_cmd.c:2827: warning: ‘ret’ may be used uninitialized in this function
responder/nss/nsssrv_cmd.c: In function ‘nss_cmd_getpwnam_callback’:
responder/nss/nsssrv_cmd.c:288: warning: ‘ret’ may be used uninitialized in this function
responder/nss/nsssrv_cmd.c: In function ‘nss_cmd_setgrent_callback’:
responder/nss/nsssrv_cmd.c:2306: warning: ‘ret’ may be used uninitialized in this function
responder/nss/nsssrv_cmd.c: In function ‘nss_cmd_setpwent_callback’:
responder/nss/nsssrv_cmd.c:954: warning: ‘ret’ may be used uninitialized in this function
responder/nss/nsssrv_cmd.c: In function ‘nss_cmd_getpwuid_callback’:
responder/nss/nsssrv_cmd.c:657: warning: ‘ret’ may be used uninitialized in this function
=> These were found when compiling on Fedora 11 (which is using GCC 4.4.0)
{{{
Compiling responder/nss/nsssrv_cmd.c
responder/nss/nsssrv_cmd.c: In function ‘nss_cmd_getinit_callback’:
responder/nss/nsssrv_cmd.c:2827: warning: ‘ret’ may be used uninitialized in this function
responder/nss/nsssrv_cmd.c: In function ‘nss_cmd_getpwnam_callback’:
responder/nss/nsssrv_cmd.c:288: warning: ‘ret’ may be used uninitialized in this function
responder/nss/nsssrv_cmd.c: In function ‘nss_cmd_setgrent_callback’:
responder/nss/nsssrv_cmd.c:2306: warning: ‘ret’ may be used uninitialized in this function
responder/nss/nsssrv_cmd.c: In function ‘nss_cmd_setpwent_callback’:
responder/nss/nsssrv_cmd.c:954: warning: ‘ret’ may be used uninitialized in this function
responder/nss/nsssrv_cmd.c: In function ‘nss_cmd_getpwuid_callback’:
responder/nss/nsssrv_cmd.c:657: warning: ‘ret’ may be used uninitialized in this function
}}}

Fields changed

resolution: => fixed
status: new => closed

Sorry, I didn't realize until after the code was committed that there were also similar warnings in the negative cache code that need to be fixed.

Compiling responder/nss/nsssrv_nc.c
responder/nss/nsssrv_cmd.c: In function ‘nss_cmd_getinit_callback’:
responder/nss/nsssrv_cmd.c:2960: warning: ‘ret’ may be used uninitialized in this function
responder/nss/nsssrv_cmd.c: In function ‘nss_cmd_getpwnam_callback’:
responder/nss/nsssrv_cmd.c:417: warning: ‘ret’ may be used uninitialized in this function
responder/nss/nsssrv_cmd.c: In function ‘nss_cmd_getpwuid_callback’:
responder/nss/nsssrv_cmd.c:774: warning: ‘ret’ may be used uninitialized in this function

resolution: fixed =>
status: closed => reopened

Simo did fix these in r4f88dcb91128aae87c8c2d95446d5303a1b0620f

The compilation produces no errors or warning as of now (F11, gcc 4.4.0).

resolution: => fixed
status: reopened => closed

Fields changed

rhbz: => 0

Metadata Update from @sgallagh:
- Issue assigned to simo

4 years ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/1072

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Login to comment on this ticket.

Metadata