#2769 Incorrect comment in ini_augment_ut.c
Closed: Fixed None Opened 6 years ago by rharwood.

Starting at line 217:

    /* Match all that do not start with 'r'                                    
    * and end with '.conf' and then match all                                  
    * ending with '.conf' */
    const char *sections[] = { "config",
                           "monitor",
                               "domains",
                               "services",
                               "provider",
                               NULL };

This is probably a copy-paste error from immediately before it:

    /* Match all that do not start with 'r'                                    
    * and end with '.conf' and then match all                                  
    * ending with '.conf' */
    const char *patterns[] = { "#",
                           "^[^r][a-z]*\\.conf$",
                               "^real\\.conf$",
                               NULL };

Since this is test code, this bug is relatively minor; however, it does make trying to figure out how to call ini_config_augment() more difficult.

Thanks!


Fields changed

cc: => lslebodn@redhat.com
owner: somebody => rharwood

Fields changed

cc: => lslebodn@redhat.com
owner: somebody => rharwood

Fields changed

cc: => lslebodn@redhat.com
owner: somebody => rharwood

Patched pushed to master as 4b45e0a12ba5cb883891cfa0ab596c00bc9dac6a; this can therefore be closed.

Patched pushed to master as 4b45e0a12ba5cb883891cfa0ab596c00bc9dac6a; this can therefore be closed.

Patched pushed to master as 4b45e0a12ba5cb883891cfa0ab596c00bc9dac6a; this can therefore be closed.

You're right, thanks for the reminder.

btw I don't see us having an appropriate milestone for ding-libs.next, OK if I create 0.6.0 ?

You're right, thanks for the reminder.

btw I don't see us having an appropriate milestone for ding-libs.next, OK if I create 0.6.0 ?

You're right, thanks for the reminder.

btw I don't see us having an appropriate milestone for ding-libs.next, OK if I create 0.6.0 ?

Sounds good to me. Hopefully the patches I posted for #2770 and #2771 can also find their way in that way.

Sounds good to me. Hopefully the patches I posted for #2770 and #2771 can also find their way in that way.

Sounds good to me. Hopefully the patches I posted for #2770 and #2771 can also find their way in that way.

Replying to [comment:4 rharwood]:

Sounds good to me. Hopefully the patches I posted for #2770 and #2771 can also find their way in that way.

Hmm I only see one patch from you on sssd-devel..?

Replying to [comment:4 rharwood]:

Sounds good to me. Hopefully the patches I posted for #2770 and #2771 can also find their way in that way.

Hmm I only see one patch from you on sssd-devel..?

Replying to [comment:4 rharwood]:

Sounds good to me. Hopefully the patches I posted for #2770 and #2771 can also find their way in that way.

Hmm I only see one patch from you on sssd-devel..?

Fields changed

milestone: NEEDS_TRIAGE => ding-libs 0.6.0
resolution: => fixed
status: new => closed

Fields changed

milestone: NEEDS_TRIAGE => ding-libs 0.6.0
resolution: => fixed
status: new => closed

Fields changed

milestone: NEEDS_TRIAGE => ding-libs 0.6.0
resolution: => fixed
status: new => closed

Replying to [comment:5 jhrozek]:

Replying to [comment:4 rharwood]:

Sounds good to me. Hopefully the patches I posted for #2770 and #2771 can also find their way in that way.

Hmm I only see one patch from you on sssd-devel..?

That's my fault... sent to the wrong list. Should be there now.

Replying to [comment:5 jhrozek]:

Replying to [comment:4 rharwood]:

Sounds good to me. Hopefully the patches I posted for #2770 and #2771 can also find their way in that way.

Hmm I only see one patch from you on sssd-devel..?

That's my fault... sent to the wrong list. Should be there now.

Replying to [comment:5 jhrozek]:

Replying to [comment:4 rharwood]:

Sounds good to me. Hopefully the patches I posted for #2770 and #2771 can also find their way in that way.

Hmm I only see one patch from you on sssd-devel..?

That's my fault... sent to the wrong list. Should be there now.

Fields changed

rhbz: => 0

Fields changed

rhbz: => 0

Fields changed

rhbz: => 0

Metadata Update from @rharwood:
- Issue assigned to rharwood
- Issue set to the milestone: ding-libs 0.6.0

4 years ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/3810

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Login to comment on this ticket.

Metadata