#2767 The sdap_op code always ends request with EAGAIN
Closed: wontfix 4 years ago by pbrezina. Opened 8 years ago by jhrozek.

I was working on code that would re-fetch the keytab on a particular error message from connection establishment but then I found out the sdap_id_op code always ends the request with EAGAIN on failure:

688         if (ret == EOK) {
689             DEBUG(SSSDBG_TRACE_ALL,
690                   "notify connected to op #%d\n", notify_count);
691             sdap_id_op_connect_req_complete(op, DP_ERR_OK, ret);
692         } else if (is_offline) {
693             DEBUG(SSSDBG_TRACE_ALL, "notify offline to op #%d\n", notify_count);
694             sdap_id_op_connect_req_complete(op, DP_ERR_OFFLINE, EAGAIN);
695         } else {
696             DEBUG(SSSDBG_TRACE_ALL,
697                   "notify error to op #%d: %d [%s]\n", notify_count, ret, strerror(ret));
698             sdap_id_op_connect_req_complete(op, DP_ERR_FATAL, ret);
699         }
700     }

In this case, we hit the middle condition and end up offline, not the fatal error. This is really unfriendly towards the user of this interface. We should allow specific error codes.

We should work on this fix in 1.14 when we work on the syncrepl.


Fields changed

milestone: NEEDS_TRIAGE => SSSD 1.14 beta

Fields changed

rhbz: => 0

The sdap_ops code still needs more love..

milestone: SSSD 1.14 beta => SSSD 1.15 beta

Metadata Update from @jhrozek:
- Issue set to the milestone: SSSD Future releases (no date set yet)

7 years ago

Metadata Update from @thalman:
- Custom field design_review reset (from 0)
- Custom field mark reset (from 0)
- Custom field patch reset (from 0)
- Custom field review reset (from 0)
- Custom field sensitive reset (from 0)
- Custom field testsupdated reset (from 0)
- Issue close_status updated to: None
- Issue tagged with: Canditate to close

4 years ago

Thank you for taking time to submit this request for SSSD. Unfortunately this issue was not given priority and the team lacks the capacity to work on it at this time.

Given that we are unable to fulfill this request I am closing the issue as wontfix.

If the issue still persist on recent SSSD you can request re-consideration of this decision by reopening this issue. Please provide additional technical details about its importance to you.

Thank you for understanding.

Metadata Update from @pbrezina:
- Issue close_status updated to: wontfix
- Issue status updated to: Closed (was: Open)

4 years ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/3808

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Login to comment on this ticket.

Metadata