#236 Incorrect use of tevent_req_is_error()
Closed: Fixed None Opened 14 years ago by mnagy.

In a lot of places we use tevent_req_is_error() in an incorrect way. We often don't take into account that the 'error' argument doesn't have to be set by tevent_req_is_error(). One example would be sdap_get_users_recv():

uint64_t err;

if (tevent_req_is_error(req, &tstate, &err)) {
    if (err) return err;
    return EIO;
}

This might be good enough, however, if we initialized err to 0.


Fields changed

owner: somebody => mnagy

Fields changed

owner: mnagy => jhrozek

Simo actually fixed this

owner: jhrozek => simo

Fixed in 47d61ca

fixedin: => 1.0.0rc
resolution: => fixed
status: new => closed

Fields changed

rhbz: => 0

Metadata Update from @mnagy:
- Issue assigned to simo
- Issue set to the milestone: SSSD 1.0 RC

7 years ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/1278

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Login to comment on this ticket.

Metadata