#2216 Inspect the usage of find_subdomain_by_sid
Closed: wontfix 4 years ago by pbrezina. Opened 10 years ago by jhrozek.

On some places in the code, especially those AD-centric, we search a domain by its SID.

However, some AD-specific code paths are executed based on LDAP schema for example, so the same code is executed when a domain is set with:

id_provider=ldap
ldap_schema=ad

as if it was set with:

id_provider = ad

The generic LDAP code shouldn't make assumptions on having the domain SID handy, at least until (or if) there is way for the LDAP provider to distinguish between calls made by AD provider from calls made by LDAP provider set to AD schema.


One idea might be to carry around the domain that the entry matched in instead of magically trying to match a SID unless really needed and try to remove searching for domain from the generic code.

Fields changed

rhbz: => todo

Fields changed

milestone: NEEDS_TRIAGE => SSSD 1.11.5
owner: somebody => lslebodn

This is a minor task that shouldn't block 1.11.5 and perhaps should be moved out of 1.11.x completely.

milestone: SSSD 1.11.5 => SSSD 1.11.6

As discussed on sssd-devel, we can move this ticket to 1.12.

milestone: SSSD 1.11.6 => SSSD 1.12 beta

Fields changed

milestone: SSSD 1.12 beta => SSSD 1.12.1

Fields changed

review: 0 => 1

Fields changed

rhbz: todo => 0

Mass-moving all tickets that didn't make 1.12.1 into 1.12.2

milestone: SSSD 1.12.1 => SSSD 1.12.2

We need to do a release as requested by downstream. Moving tickets that are not fixed already or very close to acking to 1.12.3

milestone: SSSD 1.12.2 => SSSD 1.12.3

It makes sense to do this work when we fork 1.13, because there is a risk of regression with the refactoring.

mark: => 0
milestone: SSSD 1.12.3 => SSSD 1.13 beta

Should be done together with the LDAP provider refactoring.

milestone: SSSD 1.13 beta => SSSD 1.13 backlog

Mass-moving tickets not planned for the 1.13 release to 1.14

milestone: SSSD 1.13 backlog => SSSD 1.14 beta

Fields changed

priority: major => minor
sensitive: => 0

This would be a good code hygiene, but not really required for 1.14..

milestone: SSSD 1.14 beta => SSSD 1.15 beta

Metadata Update from @jhrozek:
- Issue assigned to lslebodn
- Issue set to the milestone: SSSD Future releases (no date set yet)

7 years ago

Metadata Update from @thalman:
- Custom field design_review reset (from 0)
- Custom field mark reset (from 0)
- Custom field patch reset (from 0)
- Custom field review adjusted to on (was: 1)
- Custom field sensitive reset (from 0)
- Custom field testsupdated reset (from 0)
- Issue close_status updated to: None
- Issue tagged with: Canditate to close

4 years ago

Thank you for taking time to submit this request for SSSD. Unfortunately this issue was not given priority and the team lacks the capacity to work on it at this time.

Given that we are unable to fulfill this request I am closing the issue as wontfix.

If the issue still persist on recent SSSD you can request re-consideration of this decision by reopening this issue. Please provide additional technical details about its importance to you.

Thank you for understanding.

Metadata Update from @pbrezina:
- Issue close_status updated to: wontfix
- Issue status updated to: Closed (was: Open)

4 years ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/3258

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Login to comment on this ticket.

Metadata