#2185 cleanup redundant #define statements
Closed: Fixed None Opened 6 years ago by yelley.

I noticed that several files (below) specify the same #define statements.

ad_domain_info.c
#define AD_AT_OBJECT_SID "objectSID"

#define AD_AT_DNS_DOMAIN "!DnsDomain"

#define AD_AT_NT_VERSION "!NtVer"

#define AD_AT_NETLOGON "netlogon"

ad_subdomains.c
#define AD_AT_OBJECT_SID "objectSID"

#define AD_AT_DNS_DOMAIN "!DnsDomain"

#define AD_AT_NT_VERSION "!NtVer"

#define AD_AT_NETLOGON "netlogon"

ad_srv.c:
#define AD_AT_DNS_DOMAIN "!DnsDomain"

#define AD_AT_NT_VERSION "!NtVer"

#define AD_AT_NETLOGON "netlogon"


I think src/providers/ad/ad_common.h or ad_opts.h could be a good place to define these constants. Feel free to send a patch and thanks for the catch!

Fields changed

milestone: NEEDS_TRIAGE => SSSD 1.12 beta
rhbz: => 0

Fields changed

milestone: SSSD 1.12 beta => SSSD 1.12.0

Fields changed

owner: somebody => preichl

Fields changed

patch: 0 => 1

resolution: => fixed
status: new => closed

Metadata Update from @yelley:
- Issue assigned to preichl
- Issue set to the milestone: SSSD 1.12.0

3 years ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/3227

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Login to comment on this ticket.

Metadata