#2149 Add a contrib script to prepare two SRPMs for covscan-diff
Closed: Fixed None Opened 6 years ago by jhrozek.

Our Coverity server allows for diffing two SRPMs. We should add a script that would prepare a baseline SRPM and one with patches for review to ease running the scans.


Fields changed

cc: => nkinder

Fields changed

rhbz: => 0

I have just implemented something similar for 389 Directory Server. You might be able to reuse some of my work. The ticket and patch are available here:

https://fedorahosted.org/389/ticket/47611

You don't need to create two SRPMs. You simply need one SRPM where the source tarball is your baseline, and any new code that you want to scan is contained in patches that are applied in the specfile. You can read the details in the 389 DS ticket, but the general workflow that I decided on is to allow a developer to create SRPM where a patch contains a diff between two git branches. This is easily done with two simple commands:

git diff master workbranch > rpm/workbranch.patch
make -f rpm.mk patch_srpms

Hopefully you can reuse some of this for SSSD. Let me know if you have any questions.

Fields changed

milestone: NEEDS_TRIAGE => SSSD 1.12 beta

Fields changed

milestone: SSSD 1.12 beta => SSSD 1.12.0

Fields changed

owner: somebody => lslebodn

Fields changed

patch: 0 => 1
status: new => assigned

- f31b698549231d68451dbb8fd1184ad375eb5e64
- 772f80ea8bc2eefa2bff3873187ea9433b14562a

resolution: => fixed
status: assigned => closed

Metadata Update from @jhrozek:
- Issue assigned to lslebodn
- Issue set to the milestone: SSSD 1.12.0

3 years ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/3191

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Login to comment on this ticket.

Metadata