#1991 Make return codes of basic sysdb operations consistent
Closed: Fixed None Opened 5 years ago by jhrozek.

The return codes of various sysdb operations differ. Some search operations would return ENOENT if they don't find a matching object some would return EOK but an empty result list. This leads to bugs like #1989 where the programmer is not sure what the particular search function returns.

We should make sure that all functions of the same family (all delete functions, all search functions etc) behave consistently.


Fields changed

changelog: => N/A internal task only

Fields changed

milestone: NEEDS_TRIAGE => SSSD 1.12 beta
priority: minor => critical
rhbz: => 0

Fields changed

milestone: SSSD 1.12 beta => Interim Bucket
priority: critical => major

Fields changed

milestone: Interim Bucket => SSSD 1.12 beta

When implementing this ticket, please check our usage of tevent_req_error(req, ENOENT). The tevent requests should be consistent as well. We might not catch all cases, but checking the explicit use of ENOENT to terminate a request would be a good start.

Fields changed

owner: somebody => preichl

Fields changed

milestone: SSSD 1.12 beta => SSSD 1.12.1

netgroup related changes landed upstream:
- 8ca1875
- 50c009a
- 9436c86
- 940dd08
- 5153e8b

Fields changed

design: => N/A not needed

Fields changed

review: 0 => 1

another change in master - 6160202

Mass-moving all tickets that didn't make 1.12.1 into 1.12.2

milestone: SSSD 1.12.1 => SSSD 1.12.2

We need to do a release as requested by downstream. Moving tickets that are not fixed already or very close to acking to 1.12.3

milestone: SSSD 1.12.2 => SSSD 1.12.3

This is an ongoing task. We're accepting patches as they are reviewed on sssd-devel.

mark: => 0
milestone: SSSD 1.12.3 => SSSD 1.12.4

another patch landed in master - a5b55bd

Fields changed

patch: 0 => 1

More patches landed in the master:
13c0cf8
d7b9092
4bbcc2d

I think that this ticket might be considered as done. Related work will be done in #2479.

Fields changed

resolution: => fixed
status: new => closed

Metadata Update from @jhrozek:
- Issue assigned to preichl
- Issue marked as depending on: #2381
- Issue set to the milestone: SSSD 1.12.4

2 years ago

Login to comment on this ticket.

Metadata