#1969 dead code in SRV resolution
Closed: Fixed None Opened 7 years ago by jhrozek.

289    ret = fo_discover_srv_recv(state, subreq,
290                               &state->dns_domain,
291                               &state->primary_servers,
292                               &state->num_primary_servers);
293    talloc_zfree(subreq);

cond_const: Condition "ret != 0", taking false branch. Now the value of "ret" is equal to 0.
294    if (ret != EOK) {
295        goto done;
296    }
297
298    if (state->backup_domain == NULL) {
299        DEBUG(SSSDBG_TRACE_FUNC, ("No backup domain specified\n"));
300

const: At condition "ret == 1432158224", the value of "ret" must be equal to 0.

dead_error_condition: The condition "ret == 1432158224" cannot be true.

const: At condition "ret == 1432158225", the value of "ret" must be equal to 0.

dead_error_condition: The condition "ret == 1432158225" cannot be true.
301        if (ret == ERR_SRV_NOT_FOUND || ret == ERR_SRV_LOOKUP_ERROR) {
302            DEBUG(SSSDBG_MINOR_FAILURE, ("Unable to retrieve primary nor "

CID 11640 (#1 of 1): Logically dead code (DEADCODE)dead_error_begin: Execution cannot reach this statement "do {
int __debug_macro_ne...".
303                  "backup servers [%d]: %s\n", ret, sss_strerror(ret)));
304        }

Fields changed

milestone: NEEDS_TRIAGE => SSSD 1.10.1

Fields changed

rhbz: => 0

Fields changed

patch: 0 => 1

milestone: SSSD 1.10.1 => SSSD 1.10.0
resolution: => fixed
status: new => closed

Metadata Update from @jhrozek:
- Issue assigned to pbrezina
- Issue set to the milestone: SSSD 1.10.0

3 years ago

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/3011

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Login to comment on this ticket.

Metadata