Issue #1945: Enable printf format string checking in function debug_fn - sssd

SSSD / sssd

#1945 Enable printf format string checking in function debug_fn

Closed: Fixed None Opened 10 years ago by lslebodn.

Function debug_fn is indirectly used in DEBUG macro.
All arguments should be type-checked against a format string.
So it would not be possible to forget argument(s) or to pass argument with different type (may cause segfault)

lslebodn commented 10 years ago

critical format string issues fixed in master: 7486dea

missing arguments.
format '%s', but argument is integer.
wrong format string, example: '%\n'

lslebodn commented 10 years ago

Patch enables printf format string checking in function debug_fn
attribute_format.patch

lslebodn commented 10 years ago

There left 149 warnings after fixing critical issues.
Warnings will be visible after applying patch attribute_format.patch. These are mostly incorrect integer formatting

Example:[[BR]]
warning: format '%d' expects argument of type 'int', but argument 2 has type 'long int'

format should be changed to '%ld'[[BR]]

warning: format '%d' expects argument of type 'int', but argument 2 has type 'size_t'

c99 standard says 'z' modifier should be used -> format should be '%zu'

_comment0: There left 149 warnings after fixing critical issues.
Warnings will be visible after applying patch attribute_format.patch. These are mostly incorrect integer formatting

Example:[[BR]]
warning: format '%d' expects argument of type 'int', but argument 2 has type 'long int'
format should be changed to '%ld'[[BR]]
warning: format '%d' expects argument of type 'int', but argument 2 has type 'size_t'
c99 standard says 'z' modifier should be used -> format should be '%zd' => 1374668894784210